Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BindingEngine): option controlling AccessMember assign behavior #329

Closed
wants to merge 1 commit into from
Closed

Conversation

jdanyow
Copy link
Contributor

@jdanyow jdanyow commented Mar 1, 2016

fixes #205

@jdanyow
Copy link
Contributor Author

jdanyow commented Mar 1, 2016

How does this look (aside from needing tests)? Can anyone think of a better name for the option?

Public API is the options property on the binding engine instance.

@EisenbergEffect
Copy link
Contributor

@jdanyow Should we log something if the settings is "false" but the instance doesn't exist?

@jdanyow
Copy link
Contributor Author

jdanyow commented Mar 1, 2016

Tough call- I think some people (myself included) would think we should log when the object is automatically created as opposed to when assignment is skipped. There are developers on both sides of this issue. Here's an example of the most common way this issue crops up: https://gist.run/?id=73ef440e9efde8b164ca

@EisenbergEffect
Copy link
Contributor

I suppose we could also have a logging setting. What do you think?

@EisenbergEffect
Copy link
Contributor

@jdanyow Where are we at on this also considering the binding behavior idea.

@jdanyow
Copy link
Contributor Author

jdanyow commented Mar 10, 2016

closing- this is not up to date with the current plan outlined in #205

@jdanyow jdanyow closed this Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding an option to control AccessMember's automatic object creation
2 participants