Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ASCOT5 submodules to point to more recent versions #13

Open
bielsnohr opened this issue Jan 6, 2022 · 0 comments
Open

Move ASCOT5 submodules to point to more recent versions #13

bielsnohr opened this issue Jan 6, 2022 · 0 comments

Comments

@bielsnohr
Copy link
Collaborator

There are a number of changes and bug fixes that have been brought into ASCOT5 since the ascot5.2 tag that Phaethon is currently pinned to. The major change is the use of momenta for particles instead of velocities. Whilst the direct benefit of this change is negligible for Phaethon itself, staying at the HEAD of the develop branch is desirable to keep up with updates.

This will also require ascot5-python to be put onto the master branch.

In both cases, the branches I am working on with minor modifications should be rebased onto the appropriate branch mentioned above.

The use of momenta will also require the methods that calculate particle energies to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant