Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject Cleanup #161

Open
2 of 7 tasks
sneakers-the-rat opened this issue Mar 9, 2022 · 1 comment
Open
2 of 7 tasks

Subject Cleanup #161

sneakers-the-rat opened this issue Mar 9, 2022 · 1 comment

Comments

@sneakers-the-rat
Copy link
Contributor

sneakers-the-rat commented Mar 9, 2022

Subject is one of our many beloved superfund sites. meta issue to track what needs to be done

  • Expose history table and all other stored data in a uniform way. it should be trivial to browse the structure of the hdf file.
  • separate some of the ungodly long methods
  • use private and public methods so it's not so polluted
  • use properties instead of trying to maintain attribute state very brittle-ly
  • Fish out code that determines file structure out into separate objects.
  • Following ^, clean up assign_protocol so it's clearer what we expect (pending a fuller restructuring of protocols in general)
  • Smooth out some of the edge cases in prepare_run and data_thread that make unpredictable and untestable behavior.
@sneakers-the-rat sneakers-the-rat changed the title Subject Clea up Subject Cleanup Mar 9, 2022
@sneakers-the-rat
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant