Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with PyYAML 6 #65

Open
Warchant opened this issue Oct 20, 2022 · 0 comments · May be fixed by #66
Open

Issue with PyYAML 6 #65

Warchant opened this issue Oct 20, 2022 · 0 comments · May be fixed by #66

Comments

@Warchant
Copy link

Warchant commented Oct 20, 2022 •
edited
Loading

Current setup.py from master https://github.com/avirshup/DockerMake/blob/master/setup.py#L19 defines dependency: pyyaml >= 5. Which is now PyYAML 6.

Version 6 made breaking change in load function (added mandatory Loader argument), so this package does not work if you just install pip install dockermake.

Proposal to fix is to freeze versions in setup.py, and in requirements.txt to use .. Then, if you do pip install -r requirements.txt it will go to setup.py and will grab deps from there.
Or, simply upgrade to pyyaml 6.
Warchant added a commit to Warchant/DockerMake that referenced this issue Oct 20, 2022
@Warchant
Restrict PyYAML version
e724a72 
Fix avirshup#65
@Warchant Warchant linked a pull request Oct 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict PyYAML version Warchant/DockerMake
1 participant
@Warchant