Validations not showed when attaching fails

[krystof-k]

Describe the bug

When attaching an association using :through, Avo doesn't show validation errors, only reloads the associations table.

Steps to Reproduce

Have field like this:

class Avo::Resources::Subscription < Avo::BaseResource
  def fields
    field :plan_variants,
      as: :has_many,
      through: :subscription_items
  end
end

Validation in the model:

class SubscriptionItem < ApplicationRecord
  belongs_to :subscription
  belongs_to :plan_variant

  validate :fail

  private

  def fail
    errors.add(:plan_variant, "already added to the subscription")
  end
end

Try to attach the record and it doesn't show the validation error.

Expected behavior & Actual behavior

Validation error is shown.

System configuration

Avo version:
3.9.1
Rails version:
7.0.8.1
Ruby version:
3.2.3
License type:

• Community
• Pro
• Advanced

Are you using Avo monkey patches, overriding views or view components?

• Yes. If so, please post code samples.
• No

Impact

• High impact (It makes my app un-usable.)
• Medium impact (I'm annoyed, but I'll live.)
• Low impact (It's really a tiny thing that I could live with.)

Urgency

• High urgency (I can't continue development without it.)
• Medium urgency (I found a workaround, but I'd love to have it fixed.)
• Low urgency (It can wait. I just wanted you to know about it.)

[adrianthedev]

I think it's a bug and Avo swallows that error.
We'll have a fix in the first half of next week.

[adrianthedev]

Please try it tomorrow with Avo 3.10 to see if this is fixed.

[adrianthedev]

This PR should have fixed that
#2905

Closing for now to keep the issue queue clean. Please re-open if this persists after tomorrow.

[krystof-k]

Just tested it in 3.10.5 and still the same case – no validation error, no message (actually now it reloads the whole page, not just the table as before if I remember correctly).

[adrianthedev]

hmmm. we'll need a reproduction repo.
I understand it might not be easy to make, but it's the only way we can run and troubleshoot the issue.

[krystof-k]

@adrianthedev hopefully I managed to do it here. (Just try to attach a team to a user.)

[adrianthedev]

Ok. Thanks! We'll have a look.