From 60c5e5fb949ce33f83aaf3c8bd92c049f5fe7d89 Mon Sep 17 00:00:00 2001 From: Adrian Marin Date: Sun, 30 Jun 2024 15:10:41 +0300 Subject: [PATCH 1/3] test: fix bad validation test --- RELEASE.MD | 4 ++-- spec/rails_helper.rb | 17 +++++++++++++++++ spec/system/avo/tags_spec.rb | 2 +- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/RELEASE.MD b/RELEASE.MD index edf27d7af5..da82b9451a 100644 --- a/RELEASE.MD +++ b/RELEASE.MD @@ -1,8 +1,8 @@ # Release schedule -A new Avo version is released every four-ish weeks, usually on Tuesday. The versioning scheme does not follow semver but a series release. +A new Avo version is released on the first Tuesday of every month. The versioning scheme does not follow semver but a series release. -The current series is series 3 (version `3.1`, `3.2`, `3.9`, etc). Every second Tuesday of the month we'll increment the minor version number (from `3.7` to `3.8`). +The current series is series 3 (version `3.1`, `3.2`, `3.9`, etc). Every first Tuesday of the month we'll increment the minor version number (from `3.7` to `3.8`). ## Patch releases diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index 6594b60af7..e299b82b9c 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -211,3 +211,20 @@ def headless_download_setup(driver) # https://github.com/titusfortner/webdrivers/issues/247 # Webdrivers::Chromedriver.required_version = "114.0.5735.90" # Webdrivers::Chromedriver.required_version = "116.0.5845.96" + +# Temporary monkeypatch +# https://github.com/rubycdp/cuprite/issues/269#issuecomment-2198532882 +module Ferrum + class Page + + def resize(width: nil, height: nil, fullscreen: false) + if fullscreen + width, height = document_size + self.window_bounds = { window_state: "fullscreen" } + else + self.window_bounds = { window_state: "normal" } + self.window_bounds = { width: width, height: height } + end + end + end +end diff --git a/spec/system/avo/tags_spec.rb b/spec/system/avo/tags_spec.rb index d18d5ec429..264815516c 100644 --- a/spec/system/avo/tags_spec.rb +++ b/spec/system/avo/tags_spec.rb @@ -98,7 +98,7 @@ save - expect(page).to have_text("Validation failed: Name can't be blank") + expect(page).to have_text("Name can't be blank") expect(page.all(".tagify__tag-text").map(&:text)).to eq ["one", "two"] end end From d0a1674cc6211d522f7b5ca4df8504a5e2e12816 Mon Sep 17 00:00:00 2001 From: Adrian Marin Date: Sun, 30 Jun 2024 21:09:28 +0300 Subject: [PATCH 2/3] update gemfiles --- Appraisals | 1 + gemfiles/rails_6.1_ruby_3.1.4.gemfile | 4 +++- gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock | 10 ++++++++-- gemfiles/rails_6.1_ruby_3.2.2.gemfile | 4 +++- gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock | 10 ++++++++-- gemfiles/rails_6.1_ruby_3.3.0.gemfile | 4 +++- gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock | 10 ++++++++-- gemfiles/rails_7.1_ruby_3.1.4.gemfile | 4 +++- gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock | 10 ++++++++-- gemfiles/rails_7.1_ruby_3.2.2.gemfile | 4 +++- gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock | 10 ++++++++-- gemfiles/rails_7.1_ruby_3.3.0.gemfile | 4 +++- gemfiles/rails_7.1_ruby_3.3.0.gemfile.lock | 10 ++++++++-- gemfiles/rails_8.0_ruby_3.1.4.gemfile | 2 ++ gemfiles/rails_8.0_ruby_3.1.4.gemfile.lock | 8 +++++++- gemfiles/rails_8.0_ruby_3.2.2.gemfile | 2 ++ gemfiles/rails_8.0_ruby_3.2.2.gemfile.lock | 8 +++++++- gemfiles/rails_8.0_ruby_3.3.0.gemfile | 2 ++ gemfiles/rails_8.0_ruby_3.3.0.gemfile.lock | 8 +++++++- 19 files changed, 94 insertions(+), 21 deletions(-) diff --git a/Appraisals b/Appraisals index f993607537..0c223ff1cf 100644 --- a/Appraisals +++ b/Appraisals @@ -3,6 +3,7 @@ appraise "rails-#{rails_version}-ruby-#{ruby_version}" do gem "psych", "< 4" gem "rails", "~> #{rails_version}" + gem "activestorage", "~> #{rails_version}" gem "ransack", "~> 4.1", ">= 4.1.1" # source "https://rubygems.pkg.github.com/avo-hq" do diff --git a/gemfiles/rails_6.1_ruby_3.1.4.gemfile b/gemfiles/rails_6.1_ruby_3.1.4.gemfile index 58743bdebe..bbf70044ff 100644 --- a/gemfiles/rails_6.1_ruby_3.1.4.gemfile +++ b/gemfiles/rails_6.1_ruby_3.1.4.gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" gem "jsbundling-rails" gem "cssbundling-rails" gem "rails", "~> 6.1" -gem "activestorage" +gem "activestorage", "~> 6.1" gem "pg", ">= 0.18", "< 2.0" gem "puma", "~> 6.4" gem "redis", "~> 5.0" @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock b/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock index 2a7a885c33..67a29a346d 100644 --- a/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock +++ b/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock @@ -13,7 +13,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -99,6 +99,10 @@ GEM zeitwerk (~> 2.3) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -580,9 +584,10 @@ PLATFORMS DEPENDENCIES active_link_to active_median - activestorage + activestorage (~> 6.1) acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -599,6 +604,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_6.1_ruby_3.2.2.gemfile b/gemfiles/rails_6.1_ruby_3.2.2.gemfile index 58743bdebe..bbf70044ff 100644 --- a/gemfiles/rails_6.1_ruby_3.2.2.gemfile +++ b/gemfiles/rails_6.1_ruby_3.2.2.gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" gem "jsbundling-rails" gem "cssbundling-rails" gem "rails", "~> 6.1" -gem "activestorage" +gem "activestorage", "~> 6.1" gem "pg", ">= 0.18", "< 2.0" gem "puma", "~> 6.4" gem "redis", "~> 5.0" @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock b/gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock index 2a7a885c33..67a29a346d 100644 --- a/gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock +++ b/gemfiles/rails_6.1_ruby_3.2.2.gemfile.lock @@ -13,7 +13,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -99,6 +99,10 @@ GEM zeitwerk (~> 2.3) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -580,9 +584,10 @@ PLATFORMS DEPENDENCIES active_link_to active_median - activestorage + activestorage (~> 6.1) acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -599,6 +604,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_6.1_ruby_3.3.0.gemfile b/gemfiles/rails_6.1_ruby_3.3.0.gemfile index 58743bdebe..bbf70044ff 100644 --- a/gemfiles/rails_6.1_ruby_3.3.0.gemfile +++ b/gemfiles/rails_6.1_ruby_3.3.0.gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" gem "jsbundling-rails" gem "cssbundling-rails" gem "rails", "~> 6.1" -gem "activestorage" +gem "activestorage", "~> 6.1" gem "pg", ">= 0.18", "< 2.0" gem "puma", "~> 6.4" gem "redis", "~> 5.0" @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock b/gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock index 2a7a885c33..67a29a346d 100644 --- a/gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock +++ b/gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock @@ -13,7 +13,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -99,6 +99,10 @@ GEM zeitwerk (~> 2.3) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -580,9 +584,10 @@ PLATFORMS DEPENDENCIES active_link_to active_median - activestorage + activestorage (~> 6.1) acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -599,6 +604,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_7.1_ruby_3.1.4.gemfile b/gemfiles/rails_7.1_ruby_3.1.4.gemfile index f570852610..59cee1181a 100644 --- a/gemfiles/rails_7.1_ruby_3.1.4.gemfile +++ b/gemfiles/rails_7.1_ruby_3.1.4.gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" gem "jsbundling-rails" gem "cssbundling-rails" gem "rails", "~> 7.1" -gem "activestorage" +gem "activestorage", "~> 7.1" gem "pg", ">= 0.18", "< 2.0" gem "puma", "~> 6.4" gem "redis", "~> 5.0" @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock b/gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock index 4f0b2aa2e7..8fef2f8a92 100644 --- a/gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock +++ b/gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock @@ -13,7 +13,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -114,6 +114,10 @@ GEM tzinfo (~> 2.0) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -611,9 +615,10 @@ PLATFORMS DEPENDENCIES active_link_to active_median - activestorage + activestorage (~> 7.1) acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -630,6 +635,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_7.1_ruby_3.2.2.gemfile b/gemfiles/rails_7.1_ruby_3.2.2.gemfile index f570852610..59cee1181a 100644 --- a/gemfiles/rails_7.1_ruby_3.2.2.gemfile +++ b/gemfiles/rails_7.1_ruby_3.2.2.gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" gem "jsbundling-rails" gem "cssbundling-rails" gem "rails", "~> 7.1" -gem "activestorage" +gem "activestorage", "~> 7.1" gem "pg", ">= 0.18", "< 2.0" gem "puma", "~> 6.4" gem "redis", "~> 5.0" @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock b/gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock index 4f0b2aa2e7..8fef2f8a92 100644 --- a/gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock +++ b/gemfiles/rails_7.1_ruby_3.2.2.gemfile.lock @@ -13,7 +13,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -114,6 +114,10 @@ GEM tzinfo (~> 2.0) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -611,9 +615,10 @@ PLATFORMS DEPENDENCIES active_link_to active_median - activestorage + activestorage (~> 7.1) acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -630,6 +635,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_7.1_ruby_3.3.0.gemfile b/gemfiles/rails_7.1_ruby_3.3.0.gemfile index f570852610..59cee1181a 100644 --- a/gemfiles/rails_7.1_ruby_3.3.0.gemfile +++ b/gemfiles/rails_7.1_ruby_3.3.0.gemfile @@ -5,7 +5,7 @@ source "https://rubygems.org" gem "jsbundling-rails" gem "cssbundling-rails" gem "rails", "~> 7.1" -gem "activestorage" +gem "activestorage", "~> 7.1" gem "pg", ">= 0.18", "< 2.0" gem "puma", "~> 6.4" gem "redis", "~> 5.0" @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_7.1_ruby_3.3.0.gemfile.lock b/gemfiles/rails_7.1_ruby_3.3.0.gemfile.lock index 4f0b2aa2e7..8fef2f8a92 100644 --- a/gemfiles/rails_7.1_ruby_3.3.0.gemfile.lock +++ b/gemfiles/rails_7.1_ruby_3.3.0.gemfile.lock @@ -13,7 +13,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -114,6 +114,10 @@ GEM tzinfo (~> 2.0) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -611,9 +615,10 @@ PLATFORMS DEPENDENCIES active_link_to active_median - activestorage + activestorage (~> 7.1) acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -630,6 +635,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_8.0_ruby_3.1.4.gemfile b/gemfiles/rails_8.0_ruby_3.1.4.gemfile index 13d4e7e653..2a8242d506 100644 --- a/gemfiles/rails_8.0_ruby_3.1.4.gemfile +++ b/gemfiles/rails_8.0_ruby_3.1.4.gemfile @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_8.0_ruby_3.1.4.gemfile.lock b/gemfiles/rails_8.0_ruby_3.1.4.gemfile.lock index 3c5b31d8f6..d621ae42ce 100644 --- a/gemfiles/rails_8.0_ruby_3.1.4.gemfile.lock +++ b/gemfiles/rails_8.0_ruby_3.1.4.gemfile.lock @@ -119,7 +119,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -146,6 +146,10 @@ GEM activesupport (>= 6.1) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -620,6 +624,7 @@ DEPENDENCIES activestorage! acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -636,6 +641,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_8.0_ruby_3.2.2.gemfile b/gemfiles/rails_8.0_ruby_3.2.2.gemfile index 13d4e7e653..2a8242d506 100644 --- a/gemfiles/rails_8.0_ruby_3.2.2.gemfile +++ b/gemfiles/rails_8.0_ruby_3.2.2.gemfile @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_8.0_ruby_3.2.2.gemfile.lock b/gemfiles/rails_8.0_ruby_3.2.2.gemfile.lock index 3c5b31d8f6..d621ae42ce 100644 --- a/gemfiles/rails_8.0_ruby_3.2.2.gemfile.lock +++ b/gemfiles/rails_8.0_ruby_3.2.2.gemfile.lock @@ -119,7 +119,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -146,6 +146,10 @@ GEM activesupport (>= 6.1) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -620,6 +624,7 @@ DEPENDENCIES activestorage! acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -636,6 +641,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise diff --git a/gemfiles/rails_8.0_ruby_3.3.0.gemfile b/gemfiles/rails_8.0_ruby_3.3.0.gemfile index 13d4e7e653..2a8242d506 100644 --- a/gemfiles/rails_8.0_ruby_3.3.0.gemfile +++ b/gemfiles/rails_8.0_ruby_3.3.0.gemfile @@ -45,6 +45,7 @@ gem "money-rails", "~> 1.12" gem "avo-money_field" gem "avo-record_link_field" gem "pagy", "> 8" +gem "csv" gem "psych", "< 4" group :development do @@ -58,6 +59,7 @@ group :development do gem "ripper-tags" gem "rubocop-shopify", require: false gem "rubycritic", require: false + gem "actual_db_schema" end group :test do diff --git a/gemfiles/rails_8.0_ruby_3.3.0.gemfile.lock b/gemfiles/rails_8.0_ruby_3.3.0.gemfile.lock index 3c5b31d8f6..d621ae42ce 100644 --- a/gemfiles/rails_8.0_ruby_3.3.0.gemfile.lock +++ b/gemfiles/rails_8.0_ruby_3.3.0.gemfile.lock @@ -119,7 +119,7 @@ PATH PATH remote: .. specs: - avo (3.7.4) + avo (3.9.2) actionview (>= 6.1) active_link_to activerecord (>= 6.1) @@ -146,6 +146,10 @@ GEM activesupport (>= 6.1) acts_as_list (1.1.0) activerecord (>= 4.2) + actual_db_schema (0.7.5) + activerecord (>= 6.0.0) + activesupport (>= 6.0.0) + csv addressable (2.8.6) public_suffix (>= 2.0.2, < 6.0) annotate (3.2.0) @@ -620,6 +624,7 @@ DEPENDENCIES activestorage! acts-as-taggable-on! acts_as_list + actual_db_schema addressable annotate appraisal @@ -636,6 +641,7 @@ DEPENDENCIES chartkick countries cssbundling-rails + csv cuprite database_cleaner-active_record devise From cba9bf54944ccf166385f142dbc3b9a4a79d0fa4 Mon Sep 17 00:00:00 2001 From: Adrian Marin Date: Sun, 30 Jun 2024 21:26:52 +0300 Subject: [PATCH 3/3] remove monkeypatch --- spec/rails_helper.rb | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index e299b82b9c..6594b60af7 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -211,20 +211,3 @@ def headless_download_setup(driver) # https://github.com/titusfortner/webdrivers/issues/247 # Webdrivers::Chromedriver.required_version = "114.0.5735.90" # Webdrivers::Chromedriver.required_version = "116.0.5845.96" - -# Temporary monkeypatch -# https://github.com/rubycdp/cuprite/issues/269#issuecomment-2198532882 -module Ferrum - class Page - - def resize(width: nil, height: nil, fullscreen: false) - if fullscreen - width, height = document_size - self.window_bounds = { window_state: "fullscreen" } - else - self.window_bounds = { window_state: "normal" } - self.window_bounds = { width: width, height: height } - end - end - end -end