Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate trial results to .pkgjogger #17

Open
awadell1 opened this issue Sep 6, 2021 · 0 comments
Open

Relocate trial results to .pkgjogger #17

awadell1 opened this issue Sep 6, 2021 · 0 comments

Comments

@awadell1
Copy link
Owner

awadell1 commented Sep 6, 2021

Moving to GIT_ROOT/.pkgjogger has several advantages

Pros

  • Easier to add to a global.gitignore (It's .pkgjogger/) where trial/ might be too broad
  • Less external folder names than PKG_DIR/benchmarks/trail (ie. what if we switch to benchmark)
  • May want to store additional information here (Like a database of trail metadata), making trials a misnomer

Cons

  • Breaking change for external tools
  • User need to relocate trail results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awadell1