Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors from benchmarking #54

Open
awadell1 opened this issue Jun 9, 2022 · 0 comments
Open

Catch errors from benchmarking #54

awadell1 opened this issue Jun 9, 2022 · 0 comments
Assignees
Labels
tui Related to PkgJogger's Text User Interface

Comments

@awadell1
Copy link
Owner

awadell1 commented Jun 9, 2022

TUI should catch and display errors when benchmarking but not quit

julia> JogDeepDFN.tui()
[q]uit. [] to Deselect. [] to Select. [␣] to Fold. [↵] confirm selection.
Mode: [b]enchmark j[u]dge
Actions: [r]evise. change re[f]erence. sho[w] reference
Reference: latest
Options: [v]erbose. [s]ave. reuse [t]une.
 +   ✓ bench_dataloader.jl
 + ▶ ◔ bench_dim_project.jl
(1/2) benchmarking "bench_dataloader.jl"...
  (1/2) benchmarking "InMemoryDFNDataset"...
    (1/3) benchmarking "FixedDuration"...
      (1/3) benchmarking "getobs!-rand"...
      done (took 1.014676201 seconds)
      (2/3) benchmarking "getobs!-1"...
      done (took 0.020244043 seconds)
      (3/3) benchmarking "getobs!-rand(32)"...
      done (took 0.063939834 seconds)
    done (took 2.25188201 seconds)
    (2/3) benchmarking "FixedDuration - Dataloader"...
      (1/2) benchmarking "basic"...
ERROR: UndefVarError: dl not defined
Stacktrace:
  [1-28]  internal
       @ Main.JogDeepDFN.##bench_dataloader.jl#355, BenchmarkTools, Main.JogDeepDFN, PkgJogger.TUI, Unknown
    [29] tui()
       @ Main.JogDeepDFN ~/.julia/packages/PkgJogger/D1SGH/src/jogger.jl:236
    [30] top-level scope
       @ REPL[3]:1
Use `err` to retrieve the full stack trace.

@awadell1 awadell1 added the tui Related to PkgJogger's Text User Interface label Jun 9, 2022
@awadell1 awadell1 self-assigned this Jun 10, 2022
awadell1 added a commit that referenced this issue Jun 10, 2022
Fixes #54

Also start building out a testing suite for the TUI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tui Related to PkgJogger's Text User Interface
Projects
None yet
Development

No branches or pull requests

1 participant