Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST to seperate package #116

Open
rsoeldner opened this issue Sep 30, 2019 · 3 comments · May be fixed by #180
Open

AST to seperate package #116

rsoeldner opened this issue Sep 30, 2019 · 3 comments · May be fixed by #180

Comments

@rsoeldner
Copy link

Hi,

any chance to put Proto3.Suite.DotProto in a separate package?
When trying to use the entire package under nix, I receive

Error: Package ‘range-set-list-0.1.3’ in /nix/store/sh0np54inv4wrfslsnsz2kjlialm67da-N/pkgs/development/haskell-modules/hackage-packages.nix:184457 is marked as broken, refusing to evaluate.

using the following pinning:

let proto3Overlay = self: super: {
      haskellPackages = super.haskellPackages.override {
        overrides = hself: hsuper:
          {
            mkDerivation = args: hsuper.mkDerivation (args // { enableLibraryProfiling = true; });
            proto3-wire = hself.callCabal2nix "proto3-wire" ./proto3-wire {};
            proto3-suite = hself.callCabal2nix "proto3-suite" ./proto3-suite {};
          };
        };
      };
in import (builtins.fetchTarball
    {name = "N";
     url = "https://github.com/nixos/nixpkgs/archive/f52505fac8c82716872a616c501ad9eff188f97f.tar.gz";
     sha256 = "0q2m2qhyga9yq29yz90ywgjbn9hdahs7i8wwlq7b55rdbyiwa5dy";
    }) { config = {}; overlays = [ proto3Overlay ]; }
@Gabriella439
Copy link
Contributor

@rsoeldner: That seems reasonable to me. I'd accept a pull request to factor out the AST parsing/rendering logic

@rsoeldner
Copy link
Author

@Gabriel439 do you want me to add a new repository for the ast part or should I modify the proto3-suite ?

@Gabriella439
Copy link
Contributor

@rsoeldner: Sorry for the delay. What you can do is to put this in a subdirectory of this repository (similar to how we put the grpc-haskell-core package as a subdirectory of the grpc-haskell repository)

@riz0id riz0id linked a pull request Feb 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants