Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPA recommendations #2

Open
nils-werner opened this issue Feb 9, 2015 · 4 comments
Open

PyPA recommendations #2

nils-werner opened this issue Feb 9, 2015 · 4 comments

Comments

@nils-werner
Copy link

In order for your package to be useful for others you should really refactor your project structure to be in line with the PyPA recommendations so it can be installed using pip:

  • Put everything in a libermate subdirectory
  • Create a setup.py file that declares all dependencies.
  • Gitignore pyc files
@awesomebytes
Copy link
Owner

Thank you very much for your kind comment. I must say I have no time to dedicate to this package, which my understanding of it's inner works is out of my current scope... Also, I didn't write this package, I merely revived it from some dark corner from the internet where I found it. There is a fork a bit more cleaned up here:
https://github.com/macroeyes/libermate
By @macroeyes . Maybe he would like to dedicate a bit of time to it. The thing is, as you can read in:
https://github.com/awesomebytes/libermate/blob/master/notes_on_using_libermate.txt

There are many many problems with this package.
I just gave a look to:
https://github.com/victorlei/smop

Which at the time I worked on this was not working, but it seems it has advanced a lot! @victorlei has also prepared it for packaging :)

So yeah, thanks again for your comment and if you are interested in using this kind of package I hope the extra info is useful for you.

@ghost
Copy link

ghost commented Sep 7, 2018

Hi, @nils-werner @awesomebytes , For this package to be maintained I did as you said, but it still doesn't work. I created a gitignore file with *.pyc but the error is still the same:
Changes to be committed:
(use "git rm --cached ..." to unstage)

new file:   .all.json.swp
new file:   .gitignore
new file:   .gitnore.swp
new file:   BaseRules.py
new file:   COPYING.txt
new file:   ChangeList
new file:   CommandLine.py
new file:   FunctionTim/clusterization.m
new file:   FunctionTim/clusterization.py
new file:   FunctionTim/declusterization2.m
new file:   FunctionTim/declusterization2.py
new file:   FunctionTim/diffusion_precipitation.m
new file:   FunctionTim/diffusion_precipitation.py
new file:   FunctionTim/diffusionf.m
new file:   FunctionTim/fusion.m
new file:   FunctionTim/fusion.py
new file:   Mat2Py.py
new file:   MatlabLexer.py
new file:   MatlabParser.py
new file:   README.md
new file:   RuleEngine.py
new file:   antlr.py
new file:   astrules.clp
new file:   hola.gitignore
new file:   libermate
new file:   libermate.py
new file:   matcompat.py
new file:   notes_on_using_libermate.txt
new file:   setup.py
new file:   testit.py
new file:   translate_new.py

TimNemo:libermate Tim$ python libermate.py FunctionTim/declusterization2.m
<function rule_callback at 0x101b69230>


Opening File FunctionTim/declusterization2.m
Starting Parser
The following appear to be variables:
Ni, Nb, cluster, result, Vtot, nbb, size, index, Lcluster, nb, Mtot, prop, reaction_data, type, R4, E, R1, R2, R3, Mi, dx4, M, ntot, dat, ion, R, Edisp, jj, Rcluster, Z, distance, P, i, reaction_nb, kk, depth, fdata, y, x, z
The following appear to be functions:
pi, fscanf, floor, fclose, sqrt, declusterization2, fopen, inf
syntax error: :61:1:
Parser Complete
Starting Translator
Translation Complete
writing to file FunctionTim/declusterization2.py
TimN:libermate Tim$ python libermate.py FunctionTim/declusterization2.m
<function rule_callback at 0x1033bc230>
Maybe there's a problem with my git... Could you help me please

@awesomebytes
Copy link
Owner

Don't use this package, hasn't been touched in ages. Go for

https://github.com/victorlei/smop

@ghost
Copy link

ghost commented Sep 7, 2018

@awesomebytes I have already tried to use smop from victorlei but I have an error from the beginning that I can't fix. Can you see this question victorlei/smop#132 please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants