Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when no secrets are present #119

Open
cloudshiftchris opened this issue Apr 29, 2024 · 1 comment
Open

Don't fail when no secrets are present #119

cloudshiftchris opened this issue Apr 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cloudshiftchris
Copy link

Currently, when loading secrets, if no secrets are found an exception is thrown:

if (secretsList.length === 0){
      throw new Error(`No matching secrets were returned for prefix "${prefix}".`);
}

There are valid use cases where secrets may not (yet/ever) be present, such as using this action in a reusable composite GitHub Action, where any given repository may access AWS accounts that may or may not have secrets in Secrets Manager (if they do, they will be exposed).

Proposing adding a flag such as fail-on-empty-secrets to facilitate this.

@jbct jbct added the enhancement New feature or request label May 13, 2024
@jbct
Copy link

jbct commented May 13, 2024

Thanks for the report, @cloudshiftchris. We have added this as an enhancement request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants