Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify Github App posts empty preview link on the PR even if deployment was skipped because of AMPLIFY_DIFF_DEPLOY #3959

Open
3 tasks done
taraspos opened this issue Oct 23, 2024 · 2 comments
Labels
feature-request New feature or request

Comments

@taraspos
Copy link

Before opening, please confirm:

Amplify Hosting feature

Deployments, Frontend builds, Git providers, Web previews

Is your feature request related to a problem? Please describe:

We are using Amplify Hosting with a connected GitHub provider.

When using Amplify Hosting with GitHub Pull Request previews, and when AMPLIFY_DIFF_DEPLOY is enabled, deployments are skipped as expected if no changes are detected. However, the GitHub Amplify App still posts a preview URL in Pull Request comments. This URL leads to a 404 error (or the Amplify welcome page) because nothing was deployed.

Describe how you'd like this feature to work

Amplify PR Preview URL should be posted only if deployment happened.

@taraspos taraspos added the feature-request New feature or request label Oct 23, 2024
Copy link

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant