From 2fe22d96c76e2a52bdb4f66b91c92b75a58521c5 Mon Sep 17 00:00:00 2001
From: Hui Zhao <zhohz@amazon.com>
Date: Tue, 27 Aug 2024 20:10:32 -0700
Subject: [PATCH] fix(adapter-nextjs): duplicate response Set-Cookie headers in
 pages router

---
 ...okieStorageAdapterFromNextServerContext.ts | 49 ++++++++++++++-----
 1 file changed, 37 insertions(+), 12 deletions(-)

diff --git a/packages/adapter-nextjs/src/utils/createCookieStorageAdapterFromNextServerContext.ts b/packages/adapter-nextjs/src/utils/createCookieStorageAdapterFromNextServerContext.ts
index 843235b7288..52996006167 100644
--- a/packages/adapter-nextjs/src/utils/createCookieStorageAdapterFromNextServerContext.ts
+++ b/packages/adapter-nextjs/src/utils/createCookieStorageAdapterFromNextServerContext.ts
@@ -171,20 +171,45 @@ const createCookieStorageAdapterFromGetServerSidePropsContext = (
 			return allCookies;
 		},
 		set(name, value, options) {
-			response.appendHeader(
-				'Set-Cookie',
-				`${ensureEncodedForJSCookie(name)}=${value};${
-					options ? serializeSetCookieOptions(options) : ''
-				}`,
-			);
+			const encodedName = ensureEncodedForJSCookie(name);
+
+			const existingSetCookieValues = response.getHeader('Set-Cookie');
+
+			// if the cookies have already been set, we don't need to set them again.
+			if (
+				Array.isArray(existingSetCookieValues) &&
+				existingSetCookieValues.findIndex(
+					cookieValue =>
+						cookieValue.startsWith(`${encodedName}=`) &&
+						!cookieValue.startsWith(`${encodedName}=;`),
+				) > -1
+			) {
+				return;
+			}
+
+			const setCookieValue = `${encodedName}=${value};${
+				options ? serializeSetCookieOptions(options) : ''
+			}`;
+
+			response.appendHeader('Set-Cookie', setCookieValue);
 		},
 		delete(name) {
-			response.appendHeader(
-				'Set-Cookie',
-				`${ensureEncodedForJSCookie(
-					name,
-				)}=;Expires=${DATE_IN_THE_PAST.toUTCString()}`,
-			);
+			const encodedName = ensureEncodedForJSCookie(name);
+			const setCookieValue = `${encodedName}=;Expires=${DATE_IN_THE_PAST.toUTCString()}`;
+			const existingSetCookieValues = response.getHeader('Set-Cookie');
+
+			// if the value for cookie deletion is already in the Set-Cookie header, we
+			// don't need to add the deletion value again.
+			if (
+				(typeof existingSetCookieValues === 'string' &&
+					existingSetCookieValues === setCookieValue) ||
+				(Array.isArray(existingSetCookieValues) &&
+					existingSetCookieValues.includes(setCookieValue))
+			) {
+				return;
+			}
+
+			response.appendHeader('Set-Cookie', setCookieValue);
 		},
 	};
 };