From 97998f1d47cfd2e96b05221f12af8f8fc3fdcd25 Mon Sep 17 00:00:00 2001 From: JoonWon Choi Date: Tue, 28 May 2024 15:35:57 -0700 Subject: [PATCH] fix: remove esm watch from onboarding guidelines --- CONTRIBUTING.md | 4 ++-- packages/datastore/docs/contributing.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dc31abfe277..af4b322511f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -109,7 +109,7 @@ Run watch mode while editing (auth for example): ``` npx lerna exec --scope @aws-amplify/auth yarn link -npx lerna exec --scope @aws-amplify/auth yarn build:esm:watch +npx lerna exec --scope @aws-amplify/auth yarn build:watch ``` Or run the whole library in watch mode if you are working on multiple packages @@ -117,7 +117,7 @@ Or run the whole library in watch mode if you are working on multiple packages ``` yarn build # Build the whole library yarn link-all # Make all the packages available to link -yarn build:esm:watch # All packages are building ES6 modules in watch mode +yarn build:watch # All packages are building in watch mode ``` In your sample project, you can now link specific packages diff --git a/packages/datastore/docs/contributing.md b/packages/datastore/docs/contributing.md index 93dd2ed19c2..e7ad2b30a8a 100644 --- a/packages/datastore/docs/contributing.md +++ b/packages/datastore/docs/contributing.md @@ -5,10 +5,10 @@ ## Testing DataStore changes locally - On first build: - - Within **amplify-js**: `yarn && yarn build && yarn link-all && yarn build:esm:watch` + - Within **amplify-js**: `yarn && yarn build && yarn link-all && yarn build:watch` - Within sample app: `yarn && yarn link aws-amplify && yarn link @aws-amplify/datastore && yarn start` - On subsequent builds (useful if something isn't working): - - Within **amplify-js**: `yarn clean && yarn build && yarn link-all && yarn build:esm:watch` + - Within **amplify-js**: `yarn clean && yarn build && yarn link-all && yarn build:watch` - Within sample app: `rm -rf node_modules && yarn && yarn link aws-amplify && yarn link @aws-amplify/datastore && yarn start` ## Contributing to these docs