Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-nextjs): make createAuthRouteHandlers interface work in both App and Pages routers #13840

Open
wants to merge 1 commit into
base: hui/feat/adapter-nextjs/4-check-signed-in-user
Choose a base branch
from

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 23, 2024

Description of changes

Issue #, if available

Make the public handler function type as any to let the single function to be compatible with the type checks that happens in both the App router and Pages router.

  • Runtime validation on the handler parameters are enforced.

Description of how you validated changes

  • npx next build

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF changed the title feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner fix(adapter-nextjs): make createAuthRouteHandlers interface work in both App and Pages routers Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant