Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update issue labels on external comment #3298

Closed
wants to merge 1 commit into from

Conversation

atierian
Copy link
Member

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #3298 (80f22f4) into main (ec5a64d) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
- Coverage   64.50%   64.50%   -0.01%     
==========================================
  Files        1075     1075              
  Lines       35880    35880              
==========================================
- Hits        23146    23143       -3     
- Misses      12734    12737       +3     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.15% <ø> (ø)
Amplify 47.84% <ø> (ø)
Analytics_plugin_unit_test 81.37% <ø> (ø)
Auth_plugin_unit_test 74.07% <ø> (-0.02%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.08% <ø> (-0.02%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 60.29% <ø> (ø)
Storage_plugin_unit_test 54.24% <ø> (ø)
unit_tests 64.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atierian
Copy link
Member Author

atierian commented Jan 3, 2024

closing in favor of #3428

@atierian atierian closed this Jan 3, 2024
@atierian atierian deleted the remove-pending-response-on-comment branch March 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants