Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve swiftlint errors and warnings for Amplify API plugin #3441

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Jan 2, 2024

Issue #

Description

  • resolve swiftlint errors and warnings for Amplify API plugin
  • only contains formatting changes, no functional changes

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner January 2, 2024 19:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11c11d0) 68.11% compared to head (09403e5) 68.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           chore/swiftlint_core    #3441      +/-   ##
========================================================
- Coverage                 68.11%   68.08%   -0.03%     
========================================================
  Files                      1086     1086              
  Lines                     36307    36307              
========================================================
- Hits                      24730    24721       -9     
- Misses                    11577    11586       +9     
Flag Coverage Δ
API_plugin_unit_test 67.07% <100.00%> (ø)
AWSPluginsCore 64.13% <ø> (ø)
Amplify 48.10% <ø> (-0.07%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.09% <ø> (-0.04%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.00% <ø> (-0.02%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.22% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.10% <ø> (ø)
unit_tests 68.08% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -142,7 +141,7 @@ public class AppSyncListProvider<Element: Model>: ModelListProvider {
AWSAppSyncListResponse from: \(graphQLData)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the theme/highlighting

@@ -127,25 +127,25 @@ public struct AppSyncModelMetadataUtils {
""")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the theme/highlighting

Copy link
Member

@thisisabhash thisisabhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from chore/swiftlint_core to chore/swiftlint January 3, 2024 20:39
@phantumcode phantumcode merged commit 8f12e40 into chore/swiftlint Jan 3, 2024
72 checks passed
@phantumcode phantumcode deleted the chore/swiftlint_api branch January 3, 2024 20:40
phantumcode added a commit that referenced this pull request Jan 4, 2024
* chore: resolve swiftlint errors and warnings in amplify categories and amplify core (#3440)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings for Amplify API plugin (#3441)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings for Amplify Auth plugin (#3442)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Datastore plugin (#3443)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings in Amplify Storage plugin (#3444)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Analytics plugin (#3445)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Push Notifications plugin (#3446)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Predictions plugin (#3447)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings for Amplify Logging plugin (#3448)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants