Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve SwiftLint errors and warnings #3451

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Jan 3, 2024

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…d amplify core (#3440)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings
…3441)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings
…3442)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings
…ugin (#3443)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings
#3444)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings
)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings
…ations plugin (#3446)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings
…plugin (#3447)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings
…in (#3448)

* chore: resolve swiftlint errors

* chore: resolve swiftlint warnings

* chore: resolve swiftlint warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings

* chore: resolve swiftlint errors and warnings
@phantumcode phantumcode requested a review from a team as a code owner January 3, 2024 20:45
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 55.79710% with 61 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (a0ee257) to head (6123cfd).
Report is 289 commits behind head on main.

Files with missing lines Patch % Lines
.../Categories/Auth/AuthCategory+ClientBehavior.swift 0.00% 11 Missing ⚠️
...fy/Categories/Auth/AuthCategory+UserBehavior.swift 12.50% 7 Missing ⚠️
...ntBehavior/AWSCognitoAuthPlugin+UserBehavior.swift 0.00% 5 Missing ⚠️
...s/SignIn/DeviceSRPAuth/InitiateAuthDeviceSRP.swift 0.00% 4 Missing ⚠️
...CognitoAuthPlugin/Task/AWSAuthDeleteUserTask.swift 0.00% 4 Missing ⚠️
...re/Auth/Provider/AmplifyAWSSignatureV4Signer.swift 0.00% 4 Missing ⚠️
.../Core/AWSPluginsCore/Keychain/KeychainStatus.swift 0.00% 4 Missing ⚠️
...e/AWSPluginsCore/Keychain/KeychainStoreError.swift 0.00% 3 Missing ⚠️
...sPlugin/Liveness/Service/FaceLivenessSession.swift 0.00% 3 Missing ⚠️
.../Categories/Auth/AuthCategory+DeviceBehavior.swift 0.00% 2 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
- Coverage   68.13%   67.82%   -0.32%     
==========================================
  Files        1085     1078       -7     
  Lines       36248    36296      +48     
==========================================
- Hits        24699    24619      -80     
- Misses      11549    11677     +128     
Flag Coverage Δ
API_plugin_unit_test 67.07% <100.00%> (ø)
AWSPluginsCore 64.13% <26.66%> (-0.26%) ⬇️
Amplify 48.10% <34.21%> (-0.12%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.91% <55.26%> (-0.12%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.26% <90.47%> (-1.01%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.34% <87.50%> (+0.11%) ⬆️
Predictions_plugin_unit_test 37.16% <20.00%> (-0.14%) ⬇️
PushNotifications_plugin_unit_test 87.13% <100.00%> (+0.09%) ⬆️
Storage_plugin_unit_test 77.51% <ø> (-0.59%) ⬇️
unit_tests 67.82% <55.79%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode merged commit 659e861 into main Jan 4, 2024
76 checks passed
@phantumcode phantumcode deleted the chore/swiftlint branch January 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants