Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LivenessCameraModule not compatible with bootstrap 5 #4597

Closed
4 tasks done
marcelcaferati opened this issue Oct 27, 2023 · 1 comment
Closed
4 tasks done

LivenessCameraModule not compatible with bootstrap 5 #4597

marcelcaferati opened this issue Oct 27, 2023 · 1 comment
Labels
bug Something isn't working Liveness pending-maintainer-response Issue is pending response from an Amplify UI maintainer

Comments

@marcelcaferati
Copy link

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React

Which UI component?

Liveness

How is your app built?

CRA

What browsers are you seeing the problem on?

Chrome, Firefox, Microsoft Edge, Safari, iOS (React Native), Android (React Native)

Which region are you seeing the problem in?

us-east-1

Please describe your bug.

When using bootstrap 5 the Freshness Canva wont show up, the screen wont flash the colors which will reduce the Confidence level in about 25-30 points.

The error happens because the this component has a "hidden" property in the line 176

Bootstrap has a CSS property inside their reset module which adds display block to every component with the "hidden" property

What's the expected behaviour?

The amplify liveness component is supposed to work without being affected by other libraries, since aws launched their face liveness feature, people will start integrating it inside their existing aplications.

Help us reproduce the bug!

Import the default and complete boostrap and run the example from this tutorial
https://ui.docs.amplify.aws/react/connected-components/liveness

Code Snippet

[hidden] {
  display: none !important;
}
<View
  as="canvas"
  ref={freshnessColorRef}
  className={LivenessClassNames.FreshnessCanvas}
  hidden
/>

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added the pending-triage Issue is pending triage label Oct 27, 2023
@esauerbo esauerbo added bug Something isn't working Liveness and removed pending-triage Issue is pending triage labels Oct 27, 2023
@reesscot
Copy link
Contributor

@marcelcaferati See: #4413 (comment) for a workaround

I'm going to mark this as closed without a plan to fix. We do try to be good "neighbors" with other design systems/tooling but the issue here is really with Bootstrap css overreaching with its hidden attribute !important styling. Please feel free to open a new issue if there is anything else we can help with.

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Liveness pending-maintainer-response Issue is pending response from an Amplify UI maintainer
Projects
None yet
Development

No branches or pull requests

3 participants