Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR (Authenticator): Dismiss button for modal variant #4824

Open
2 tasks
OperationalFallacy opened this issue Dec 8, 2023 · 2 comments
Open
2 tasks

FR (Authenticator): Dismiss button for modal variant #4824

OperationalFallacy opened this issue Dec 8, 2023 · 2 comments
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component feature-request Request a new feature

Comments

@OperationalFallacy
Copy link

OperationalFallacy commented Dec 8, 2023

On which framework/platform would you like to see this feature implemented?

React

Which UI component is this feature-request for?

Authenticator

Please describe your feature-request in detail.

I was looking to have a dismiss button on the Authenticator and couldn't figure out how to add it

That's my best shot :)
It works except the double border between component and the additional box

image

Please describe a solution you'd like.

Is it possible to make it prettier with current design and override capabilities?

Would it make sense to add the cancel button as part of the component itself?

Thank you!

We love contributors! Is this something you'd be interested in working on?

  • 👋 I may be able to implement this feature request.
  • ⚠️ This feature might incur a breaking change.
@OperationalFallacy OperationalFallacy added the feature-request Request a new feature label Dec 8, 2023
@github-actions github-actions bot added the pending-triage Issue is pending triage label Dec 8, 2023
@esauerbo esauerbo added Authenticator An issue or a feature-request for an Authenticator UI Component and removed pending-triage Issue is pending triage labels Dec 10, 2023
@ioanabrooks ioanabrooks changed the title Authenticator design with dismiss button FR (Authenticator): Dismiss button for modal variant Dec 12, 2023
@esauerbo
Copy link
Contributor

Hi @OperationalFallacy, thanks for making this feature request! We'll discuss as a team and consider adding it to our roadmap.

@yatsky
Copy link

yatsky commented Aug 11, 2024

hi @esauerbo , is there any updates on this? A bit surprised this is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

3 participants