Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Striped Variation Does Not Work #4885

Closed
4 tasks done
thomas-j-moffett opened this issue Jan 4, 2024 · 3 comments · Fixed by #4889
Closed
4 tasks done

Table Striped Variation Does Not Work #4885

thomas-j-moffett opened this issue Jan 4, 2024 · 3 comments · Fixed by #4889
Labels
bug Something isn't working Primitive An issue or a feature-request for one or more UI Primitive

Comments

@thomas-j-moffett
Copy link

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React

Which UI component?

Primitive components

How is your app built?

Create React App

What browsers are you seeing the problem on?

Chrome

Which region are you seeing the problem in?

No response

Please describe your bug.

The table variation of "striped" doesn't work. I am using version 6.1.0 of @aws-amplify/ui-react package.

What's the expected behaviour?

The striped variation should make the table striped.

Help us reproduce the bug!

This can easily be seen in your own documentation here: https://ui.docs.amplify.aws/react/components/table?tab=#variation

It seems to work if I manually add data-variation="striped" to the table element while modifying the HTML in Chrome dev tools on your documentation page linked above. It seems that there is a amplify-table--bordered CSS class generated for the bordered one, and there is a corresponding CSS rule in the source. There is also a amplify-table--striped CSS class generated for the striped table, but no corresponding CSS rule could be found. I did find the data-variation="striped" in the source which is why I tried it out.

Code Snippet

// Put your code below this line.

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added the pending-triage Issue is pending triage label Jan 4, 2024
@ioanabrooks
Copy link
Contributor

@thomas-j-moffett Thank you for bringing this to our attention, will be addressed asap.

@ioanabrooks ioanabrooks added bug Something isn't working Primitive An issue or a feature-request for one or more UI Primitive and removed pending-triage Issue is pending triage labels Jan 5, 2024
@ioanabrooks
Copy link
Contributor

@thomas-j-moffett We just released @aws-amplify/[email protected] with this fix!

@thomas-j-moffett
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Primitive An issue or a feature-request for one or more UI Primitive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants