Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue peer dependency is missing #4958

Closed
4 tasks done
ErikCH opened this issue Jan 26, 2024 · 1 comment
Closed
4 tasks done

Vue peer dependency is missing #4958

ErikCH opened this issue Jan 26, 2024 · 1 comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component Vue An issue or a feature-request for Vue platform

Comments

@ErikCH
Copy link
Contributor

ErikCH commented Jan 26, 2024

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

Vue

Which UI component?

Authenticator

How is your app built?

Vite

What browsers are you seeing the problem on?

No response

Which region are you seeing the problem in?

No response

Please describe your bug.

The Vue package.json is missing the peer dependency for >= 3. Since the library only works with Vue 3 and higher, if a user installs the UI packages with Vue 2, npm won't warn them that they don't satisfy the peer dependency.

This would also align with Angular and React package.json.

What's the expected behaviour?

The Vue package should have the correct peer dependency.

Help us reproduce the bug!

Try to install the ui-vue package in Vue 2. Missing warning error from npm.

Code Snippet

// Put your code below this line.

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added the pending-triage Issue is pending triage label Jan 26, 2024
@reesscot reesscot added Authenticator An issue or a feature-request for an Authenticator UI Component Vue An issue or a feature-request for Vue platform and removed pending-triage Issue is pending triage labels Jan 27, 2024
@calebpollman
Copy link
Member

@ErikCH Not sure how we missed this! Addressed in #4964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component Vue An issue or a feature-request for Vue platform
Projects
None yet
Development

No branches or pull requests

3 participants