Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SV Translations #6286

Open
4 tasks done
berg-dee opened this issue Jan 8, 2025 · 3 comments
Open
4 tasks done

Incorrect SV Translations #6286

berg-dee opened this issue Jan 8, 2025 · 3 comments
Labels
feature-request Request a new feature I18n An issue for a missing Localization / Translation / Internationalization

Comments

@berg-dee
Copy link

berg-dee commented Jan 8, 2025

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React, React Native

Which UI component?

Authenticator

How is your app built?

React

What browsers are you seeing the problem on?

No response

Which region are you seeing the problem in?

No response

Please describe your bug.

A few swedish translations inside packages/ui/src/i18n/dictionaries/authenticator/sv.ts are incorrect and/or missing. Some have the wrong "key" and some need some tweaks to the actual translations.

What's the expected behaviour?

The changes that are needed:

  1. Wrong key: Enter your password
    Fix: 'Enter your Password': 'Ange ditt lösenord',

  2. Wrong key: Forgot Password
    Fix: 'Forgot Password?': 'Glömt lösenord?',

  3. Incorrect translation: Fyll i din e-post
    Fix: 'Enter your email': 'Ange din e-post',

  4. Wrong key: 'Reset password'
    Fix: 'Reset Password': 'Återställ lösenord',

  5. Missing key & translation: 'Please confirm your Password': 'Bekräfta ditt lösenord',
    Fix: Just add 'Please confirm your Password': 'Bekräfta ditt lösenord',

Help us reproduce the bug!

It's related to translations, so just look at the translations

Code Snippet

These are needed:

'Enter your Password': 'Ange ditt lösenord',
'Forgot Password?': 'Glömt lösenord?',
'Enter your email': 'Ange din e-post',
'Reset Password': 'Återställ lösenord',
'Please confirm your Password': 'Bekräfta ditt lösenord',

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Jan 8, 2025
@cwomack cwomack added feature-request Request a new feature I18n An issue for a missing Localization / Translation / Internationalization and removed pending-triage Issue is pending triage labels Jan 8, 2025
@cwomack
Copy link
Member

cwomack commented Jan 8, 2025

@berg-dee, thanks for opening this issue. We'll mark this as a feature request since you could still create your own dictionary for this to work as desired, but definitely want to make sure we're using what's the most culturally accepted verbiage in the default functionality with i18n.

If you're open to it, we'd also encourage you to open a PR yourself! If not, we'll review this internally and post an update comment when we have a PR and fix in place.

@cwomack cwomack removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 8, 2025
@berg-dee
Copy link
Author

berg-dee commented Jan 9, 2025

Thanks for the response, yes I've currently just been updating the translations using putVocabularies function and overriding with only these fixes.

But I've opened a PR here now:
#6288

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 9, 2025
@cwomack
Copy link
Member

cwomack commented Jan 10, 2025

@berg-dee, thank you for opening the PR associated with this! We'll review it and get back to you with any feedback.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature I18n An issue for a missing Localization / Translation / Internationalization
Projects
None yet
Development

No branches or pull requests

2 participants