Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::Logs::LogGroup - Tags #1256

Closed
aditya2101 opened this issue Jul 29, 2022 · 5 comments
Closed

AWS::Logs::LogGroup - Tags #1256

aditya2101 opened this issue Jul 29, 2022 · 5 comments
Labels

Comments

@aditya2101
Copy link

Name of the resource

AWS::Logs::LogGroup

Resource Name

AWS::Logs::LogGroup

Issue Description

CloudFormation supports Tags property but has the following issue causing drifts:

1.)Create a new stack which does NOT contain a log group, but does have resource tags set on the stack itself (e.g., Foo=Bar)

2.)Update the stack by adding a log group which does NOT have any tags defined

3.)If you look at the log group, you'll see that the stack-level tags did propagate to the log group

4.) Update the stack by adding matching tags (i.e., Foo=Bar) explicitly to the log group

5.) Run a drift detection on the stack

The drift status will now show MODIFIED, and the details will show an expected value of {Foo=Bar, Foo=Bar}, which can never happen on the actual resource.

Expected Behavior

There should be no drift

Observed Behavior

if you currently use StackTags on your CFT Stacks, cloudformation thinks those tags are already on your loggroup and therefore will not add the tags even if you put it in your template.

Test Cases

test case same as in issue description

Other Details

No response

@ziarrdan
Copy link

ziarrdan commented Sep 7, 2022

We could not reproduce this issue. Would you please provide us with a stack ARN is case you are still having this problem?
Thank you.

@farski
Copy link

farski commented Sep 9, 2022

@ziarrdan Per #919, this issue was opened by the AWS team. It does appear that this behavior is no longer present. Was a change made? Is it expected that this behavior would change?

@rgoltz
Copy link

rgoltz commented Sep 25, 2022

Dear @aditya2101 , Dear @ziarrdan , Dear @farski ,
I've ran various scenario for tags on stack- and resource-level for AWS::Logs::LogGroup (with and without other resources inside those stacks). In all my test-cases (made in eu-central-1) the tags on the LogGroup was correct and also CFN Drift detection always reported IN_SYNC correctly.

I agree with Chris - It seems some fixes/improvments has been made here on AWS-backend. Having this said, we may should close this github-issue here, Aditya?

@aditya2101
Copy link
Author

Yes we can close the issue now.

@Risae
Copy link

Risae commented Dec 14, 2022

Shouldn't this be moved to "Shipped"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants