Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS::Scheduler::ScheduleGroup] - [Enhancement] - Implement GetAtt for the Resource Name #1718

Open
r-heimann opened this issue Jun 16, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@r-heimann
Copy link

r-heimann commented Jun 16, 2023

Name of the resource

AWS::Scheduler::ScheduleGroup

Description

Currently AWS::Scheduler::ScheduleGroup only supports Ref to get the Resource Name. Implementing this would be great.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedulegroup.html

Related to #68

@r-heimann r-heimann added the enhancement New feature or request label Jun 16, 2023
@benkehoe
Copy link
Contributor

Most resources support name and ARN, one only through Ref and one through GetAtt (maddeningly it's not consistent which one goes with which). What drives your need to use GetAtt instead of Ref?

@r-heimann
Copy link
Author

r-heimann commented Jun 16, 2023

Most resources support name and ARN, one only through Ref and one through GetAtt (maddeningly it's not consistent which one goes with which). What drives your need to use GetAtt instead of Ref?

I'm going to answer this question with a quote because this has already been answered years ago, !Ref is EVIL

Is there value in enabling the !GetAtt function to retrieve any attribute of a resource, rather than the current subset we offer?

Is +∞ an appropriate amount of value? That would make working with CloudFormation SO much easier. Personally, I avoid !Ref at all costs because I have to interrupt and go check the docs to see what !Ref returns for a specific resource type. Making the returned value explicit with !GetAtt would be YUGE!!!!

See #68

@benkehoe
Copy link
Contributor

I agree, it's annoying! And with the new resource provider model, the identifiers used for Ref have names already. But your desire for it isn't specific to this resource, correct? Instead of trying to get CloudFormation to do this on a resource-type-by-resource-type basis, I think this might be better to open an issue (or move #68) on the CloudFormation language discussion repo for a general "resource identifiers should also be named attributes" change https://github.com/aws-cloudformation/cfn-language-discussion

@r-heimann
Copy link
Author

I agree, it's annoying! And with the new resource provider model, the identifiers used for Ref have names already. But your desire for it isn't specific to this resource, correct? Instead of trying to get CloudFormation to do this on a resource-type-by-resource-type basis, I think this might be better to open an issue (or move #68) on the CloudFormation language discussion repo for a general "resource identifiers should also be named attributes" change https://github.com/aws-cloudformation/cfn-language-discussion

Yes, i would love for !Ref to die a horrible death get completely replaced by !GetAtt.
Your suggestion is a good idea, since this is a general issue with CloudFormation.

But i'm not so keen on waiting years until things actually move forward. I have, so far, good experience with small, easy to implement GitHub feature requests that the responsible Service Team may actually implement/fix.
There are also TAMs which can be used, but it always feels like a black hole that swallows all of the quality-of-life features any customer might have.
These GitHub issues are currently the only way to properly track progress, since we do not have access to the internal issue tracker and opening an AWS Ticket just to get the current internal status gets annoying after a while. If they take longer to implement this feature, every current and potential future customer will see it and is able to make up their own mind about using CloudFormation.

@r-heimann r-heimann changed the title (AWS::Scheduler::ScheduleGroup) Implement GetAtt for the Resource Name [AWS::Scheduler::ScheduleGroup] - [Enhancement] - Implement GetAtt for the Resource Name Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants