Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karpenter addon: Update add-on props related to disruption config #1099

Open
hemanth-m19 opened this issue Oct 29, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@hemanth-m19
Copy link

hemanth-m19 commented Oct 29, 2024

Describe the bug

The current implementation of the disruption consolidationPolicy in configuration does not include the WhenEmptyOrUnderutilized option, which is supported in recent versions of Karpenter.

Expected Behavior

The disruption consolidationPolicy should also allow the WhenEmptyOrUnderutilizedvalue to align with latest changes.

consolidationPolicy?: "WhenUnderutilized" | "WhenEmpty" | "WhenEmptyOrUnderutilized",

Current Behavior

The disruption consolidationPolicy allows only the following values:

consolidationPolicy?: "WhenUnderutilized" | "WhenEmpty",

Reproduction Steps

Attempt to set the consolidationPolicy to WhenEmptyOrUnderutilized.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.160.0

EKS Blueprints Version

1.16.1

Node.js Version

20.18

Environment details (OS name and version, etc.)

Ubuntu

Other information

No response

@hemanth-m19 hemanth-m19 added the bug Something isn't working label Oct 29, 2024
@choco-nishant
Copy link

choco-nishant commented Dec 16, 2024

+1

Along with this feature, it should also support consolidateAfter for underutilized nodes and terminationGracePeriod, both of which are supported in >v1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants