Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Clarify behavior when metric unit is not found #49

Open
mm318 opened this issue Jan 30, 2020 · 0 comments
Open

Clarify behavior when metric unit is not found #49

mm318 opened this issue Jan 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mm318
Copy link
Contributor

mm318 commented Jan 30, 2020

As one can see here

datum.SetUnit(Aws::CloudWatch::Model::StandardUnitMapper::GetStandardUnitForName(unit_name));

If the user-specified unit (which is a free-form std::string) is not found in unit_mapper, it will fallback to using the AWS C++ SDK's GetStandardUnitForName() function to find the corresponding relevant StandardUnit. GetStandardUnitForName() may return StandardUnit::NOT_SET.

Is this the best behavior? Why have a unit_mapper if the AWS C++ SDK already provides a GetStandardUnitForName() function?

@jaisontj jaisontj added the enhancement New feature or request label Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants