Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - eventbridge-schedule-to-cloudwatch-sam #1452

Conversation

professional-ian
Copy link
Contributor

New pattern using SAM for EventBridge Scheduler to custom metrics to CloudWatch a schedule.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

@professional-ian your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. instance: instance requires property "language"

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@professional-ian
Copy link
Contributor Author

professional-ian commented Jul 3, 2023

Pattern does not use a language, only SAM. If language property is required please advise and will update.

@julianwood julianwood assigned julianwood and unassigned mavi888 Jul 4, 2023
@julianwood
Copy link
Contributor

Looks like there are multiple patterns here, and I think one you did before.
Could you please split out and have a single pattern per PR which makes it easier to work with.

@professional-ian professional-ian deleted the professional-ian-feature-eventbridge-schedule-to-cloudwatch-sam branch July 7, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants