-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow to ignore non-image files (pdf, webm, mp4, mp3, etc.) #387
Comments
We will add an evaluation of this to our backlog |
My vision has evolved a bit since posting this, and I believe SIH should be something that would act as a "drop-in", and basically extend the capabilities of a standard CDN, not change its behavior. Concretely, that'd mean that any kind of file that isn't supported by SIH (or Sharp) should just behave as it would when not using SIH. This way, we could replace an existing CDN by SIH without fearing any kind of regression. That would be the best of both world, as we could use the powerful SIH feature if we want, or simply use it as a normal CDN.
|
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Any update? |
Hi @chrisAllfasteners and @Vadorequest, This isn't something we're currently targeting for any upcoming releases, though you could likely make this work on a basic level without too much difficulty. Something like:
One main point to keep in mind is that this would only work if you're using Thumbor-style requests (Not the base64 encoded ones) and you can find a way to match the images you'd like to send to SIH. Let me know how it goes, |
Is your feature request related to a problem? Please describe.
I want to use the CDN as a multi-purpose CDN, I wish it would behave differently when loading a PDF file, for instance
https://cdn.the-funding-place.unly.org/exe-v4/ece-v4-flyer-partenariat-caisse-depargne455.pdf will show an error, but I'd like to prompt a download instead.
It doesn't really make sense to use multiple CDN for different file types, it makes things more complex to manage.
So, I believe we should have a way to make the app behave differently depending on the file being manipulated.
The most logical choice would be that any type that isn't handled would prompt a download, I don't think we need more than that at this time, it'd be a good default behavior.
Describe the feature you'd like
Prompt a download when a file type isn't handled (pdf, etc.)
Additional context
This doesn't seem to be officially supported, but here are a few workarounds:
Could we get a better default behavior?
The text was updated successfully, but these errors were encountered: