Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally support the removal of instances tags within returned metadata #189

Open
purpleclay opened this issue Aug 7, 2022 · 2 comments
Labels
enhancement New feature or request stalebot-ignore To NOT let stalebot update or close the Issue / PR

Comments

@purpleclay
Copy link

purpleclay commented Aug 7, 2022

Describe the feature
It would be great if the mock could simulate the optional inclusion of instances tags within the returned metadata. To ensure backwards compatibility, the proposal would be to include a flag for omitting the inclusion of instance tags, --exclude-instance-tags. In doing so, the mock would need to respond in the same way as the real IMDS service by returning a 404 upon any request to the /tags instance category.

Bizarrely if you curl IMDS using the /tags/instance path, you get a 200 and a blank response. So I guess this behaviour will need to be also mimicked.

Is the feature request related to a problem?
It is an enhancement to better align the mock with the real IMDS service. It also expands the possible testing use cases

Describe alternatives you've considered
Alternative solutions for me would be to use a hybrid approach in my testing, which is cumbersome.

@purpleclay purpleclay added the enhancement New feature or request label Aug 7, 2022
@brycahta
Copy link
Contributor

Thanks for bringing this to our attention! We definitely want AEMM to align with IMDS tags behavior.

Would you be open to submitting the PR? I'd be happy to help review and get it merged in a timely manner.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Sep 11, 2022
@snay2 snay2 added stalebot-ignore To NOT let stalebot update or close the Issue / PR and removed stale Issues / PRs with no activity labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stalebot-ignore To NOT let stalebot update or close the Issue / PR
Projects
None yet
Development

No branches or pull requests

3 participants