Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change behaviour of PIP to allow more customisable flow #161

Open
kimdanielarthur-cowlabs opened this issue Sep 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@kimdanielarthur-cowlabs
Copy link

Describe the bug
This is not a bug, but more a feature request.

IOS:

  • Currently PIP works globally for all instances of IVSPlayer by default. It would be good to move the preparePictureInPicture() to be callable through javascript layer in order to specfically enable PIP for the player instance you want rather than having it be enabled by default. For example initPip({...options})

Android:

  • The current implementation on Android differs from the iOS implementation. On Android togglePip must be explicitly called in order to enter PIP mode. However with later Android its possible to setAutoEnterEnabled(true) on the PictureInPictureParams in order for the PIP mode to automatically be entered when clicking home or using swipe gesture to hide the app (like on iOS)
  • Currently there is no way to set the aspect ratio of the PIP and it defaults to horizontal aspect ratio. It would be good to have the same approach with initPip({...options}) in order to instruct both if you want it to autoEnter pip and what the desired aspect ratio would be through setAspectRatio() in setPictureInPictureParams(PictureInPictureParams)

To reproduce

  • Use current API and see that there is potential for allowing more flexible, and better usability of the PIP modes

Expected behavior
See original description

Screenshots
No screenshots

Device (please complete the following information):

  • all iOS and Android

Debug logs
Not relevant

Additional context
This is a feature request

@kimdanielarthur-cowlabs kimdanielarthur-cowlabs added the bug Something isn't working label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant