Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ecr-assets): How to control the name of the image #13416

Closed
konstantinj opened this issue Mar 5, 2021 · 3 comments
Closed

(ecr-assets): How to control the name of the image #13416

konstantinj opened this issue Mar 5, 2021 · 3 comments
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.

Comments

@konstantinj
Copy link

❓ General Issue

We want to make use of the ECR Vulnerabilities Scanner and therefore it should be possible to easily identify which image comes from which application. Having all images in one repo only with hashes and even without any meaningful tags makes no sense to me.

In the past there were several different ways setting the repo or the source/asset hash name. All of them are now deprecated.

The Question

What's the proposed way to have meaningful image names and/or tags with the latest CDK version?

Environment

  • CDK CLI Version: 1.91.0
  • Module Version: 1.91.0
  • Node.js Version: v15.11.0
  • OS: osx
  • Language (Version): all
@konstantinj konstantinj added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Mar 5, 2021
@github-actions github-actions bot added @aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets labels Mar 5, 2021
@eladb
Copy link
Contributor

eladb commented Mar 7, 2021

We think of the ECR repository used for image assets as an implementation detail.

The proposed way (which is still unsupported) is to "deploy" the image asset to a specific ECR repository using something like ecr-deployment. See #12597 for more details.

Closing this as a duplicate of #12597 - please add comment if you believe ecr-deployment will not serve your use case.

@eladb eladb closed this as completed Mar 7, 2021
@eladb
Copy link
Contributor

eladb commented Mar 7, 2021

copy @skinny85

@eladb eladb removed their assignment Mar 7, 2021
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants