Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: Provide means to link publish and deploy stages #21918

Closed
2 tasks
danieljamesscott opened this issue Sep 5, 2022 · 2 comments
Closed
2 tasks

pipelines: Provide means to link publish and deploy stages #21918

danieljamesscott opened this issue Sep 5, 2022 · 2 comments
Assignees
Labels
@aws-cdk/pipelines CDK Pipelines library feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. p1

Comments

@danieljamesscott
Copy link

Describe the feature

I would like to be able to specify a role during pipeline.addStage(), which is assumed prior to publication, and deployment. Alternatively, I would like the ability to link the publish stage with the deployment stage using some sort of name/identifier.

Use Case

I am trying to use GitHub actions with CDK pipelines: https://github.com/cdklabs/cdk-pipelines-github/

I have run into an issue where I would like to link the "publish" stages with the "deploy" stages, so that I can permit GitHub actions to assume a role in the correct account during the "publish" stage. cdklabs/cdk-pipelines-github#302

I am aware that when using CodePipeline, the account executing the pipeline would be bootstrapped into the target accounts as a trusted entity. However, when using GitHub actions to execute the pipeline, there is no "pipeline" account, and it seems overkill to create an entire AWS account, simply to handle the initial role authentication.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.40.0

Environment details (OS name and version, etc.)

macOS

@danieljamesscott danieljamesscott added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2022
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Sep 5, 2022
@mascur mascur added p1 needs-discussion This issue/PR requires more discussion with community. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 21, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 9, 2022

Since this issue is specifically about CDK Pipelines for GitHub, create the issue there instead of here: https://github.com/cdklabs/cdk-pipelines-github/

I also have to confess I don't quite understand what the request is. If the request is about allowing GitHub to access your account, the README has instructions on how to set this up. You don't necessarily need a separate pipeline account, you can directly link the account you're deploying into. You need to do a one-off deployment using cdk deploy into the target account to deploy a stack with the GitHubActionRole construct: https://github.com/cdklabs/cdk-pipelines-github/#githubactionrole-construct

@rix0rrr rix0rrr closed this as completed Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. p1
Projects
None yet
Development

No branches or pull requests

3 participants