Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for psr/cache:^3.0 #3036

Closed
1 of 2 tasks
issakujitsuk opened this issue Nov 25, 2024 · 5 comments · Fixed by #3039
Closed
1 of 2 tasks

Add support for psr/cache:^3.0 #3036

issakujitsuk opened this issue Nov 25, 2024 · 5 comments · Fixed by #3039
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@issakujitsuk
Copy link
Contributor

issakujitsuk commented Nov 25, 2024 •
edited
Loading

Describe the feature

Currently, aws-sdk-php specifies psr/cache:^1.0 in the composer.json. Please add support for psr/cache:^3.0.

Use Case

I want to update web-token/jwt-library from version 3.3.x to 3.4.x, but I'm unable to do so because aws/aws-sdk-php locks psr/cache to version 1.0.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.324.13

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.2.8, Amazon Linux 2
@issakujitsuk issakujitsuk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 25, 2024
@yenfryherrerafeliz
Copy link
Contributor

Hi @issakujitsuk, thanks for this feature request. We will be open to accept a PR contribution for this, if you are willing to provide one?
It will be something like:

"psr/cache": "^1.0 || ^2.0 || ^3.0",

Thanks!

@yenfryherrerafeliz yenfryherrerafeliz added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 25, 2024
@issakujitsuk
Copy link
Contributor Author

Thank you for your replay, @yenfryherrerafeliz.
Yes, I am willing to provide a pull request for this. I will work on it and submit it later.

issakujitsuk added a commit to issakujitsuk/aws-sdk-php that referenced this issue Nov 26, 2024
@issakujitsuk
Add support for psr/cache 2.0, 3.0
756f087 
Fix issue aws#3036
@issakujitsuk issakujitsuk mentioned this issue Nov 26, 2024
Merged
@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 27, 2024
@github-actions GitHub Actions
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@stobrien89
Copy link
Member

Thanks for the contribution @issakujitsuk!

@issakujitsuk
Copy link
Contributor Author

Thank you for merging as well, @stobrien89 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for psr/cache 2.0, 3.0 issakujitsuk/aws-sdk-php
3 participants
@issakujitsuk @yenfryherrerafeliz @stobrien89