From d4d1ae0d065edc4ac795de32996110efb7dbf0dc Mon Sep 17 00:00:00 2001 From: Grant G Date: Thu, 7 Nov 2024 15:06:00 -0800 Subject: [PATCH] fix(amazonq): update keybinding for focus chat #5910 Update the keybindings for Amazon Q's focus chat keybind to win+alt+i on Windows, cmd+alt+i on macOS, and meta+alt+i on Linux. This was requested by product to keep it consistent with the other keybinds. --- ...reaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json | 4 ++++ packages/amazonq/package.json | 6 +++--- .../src/inlineChat/controller/inlineChatController.ts | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 packages/amazonq/.changes/next-release/Breaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json diff --git a/packages/amazonq/.changes/next-release/Breaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json b/packages/amazonq/.changes/next-release/Breaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json new file mode 100644 index 00000000000..71f740f4f36 --- /dev/null +++ b/packages/amazonq/.changes/next-release/Breaking Change-7a7320b8-e8a2-4d61-8f2d-7da04f1716da.json @@ -0,0 +1,4 @@ +{ + "type": "Breaking Change", + "description": "Change focus chat keybind to win+alt+i on Windows, cmd+alt+i on macOS, and meta+alt+i on Linux" +} diff --git a/packages/amazonq/package.json b/packages/amazonq/package.json index 33977d74984..37cf850d4fb 100644 --- a/packages/amazonq/package.json +++ b/packages/amazonq/package.json @@ -609,9 +609,9 @@ "keybindings": [ { "command": "_aws.amazonq.focusChat.keybinding", - "win": "ctrl+win+i", - "mac": "ctrl+cmd+i", - "linux": "ctrl+meta+i" + "win": "win+alt+i", + "mac": "cmd+alt+i", + "linux": "meta+alt+i" }, { "command": "aws.amazonq.explainCode", diff --git a/packages/amazonq/src/inlineChat/controller/inlineChatController.ts b/packages/amazonq/src/inlineChat/controller/inlineChatController.ts index 7f692e5acf1..6d2d77eb172 100644 --- a/packages/amazonq/src/inlineChat/controller/inlineChatController.ts +++ b/packages/amazonq/src/inlineChat/controller/inlineChatController.ts @@ -286,6 +286,7 @@ export class InlineChatController { } } if (chatEvent.error) { + getLogger().error('generateAssistantResponse stream error: %s', chatEvent.error) await this.rejectAllChanges(this.task, false) void vscode.window.showErrorMessage(`Amazon Q: ${chatEvent.error.message}`) await this.updateTaskAndLenses(this.task, TaskState.Complete)