Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scipy tests for GPU based docker images #30

Open
balajisankar15 opened this issue Jul 24, 2023 · 2 comments
Open

Fix Scipy tests for GPU based docker images #30

balajisankar15 opened this issue Jul 24, 2023 · 2 comments

Comments

@balajisankar15
Copy link
Contributor

balajisankar15 commented Jul 24, 2023

Issue: Currently scipy tests are failing when running it for GPU .

More background:
In PyPi, scipy is vended out as a single package. Whereas in Conda forge, scipy is vended out as two different packages - scipy and scipy-tests. (This is a recent change that happened two months ago)

There is a possibility that either one of these packages might be out of date and indirectly causing tests to fail

Acceptance Criteria: Scipy tests should succeed for GPU based docker images. Another possible recommendation is to come up with a different testing plan for scipy.

@just4brown
Copy link
Contributor

just4brown commented Nov 2, 2023

As of 1.1.0 release, the failure presents in a new way, but the underlying problem is still the same:

Will start running test for: scipy.test.Dockerfile against: localhost/sagemaker-distribution:1.1.0-gpu
Built a test image: sha256:dc5e4b77c35d0f38d94a12bae83f12dca1dad4b7df4adb2ecfc6ca0b4964f1ad, will now execute its default CMD.
Found Nvidia driver version: 525.85.12
============================= test session starts ==============================
platform linux -- Python 3.10.13, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/sagemaker-user
plugins: anyio-3.7.1, dash-2.14.1, hypothesis-6.88.1
collected 58127 items / 1 error / 12693 deselected / 45434 selected

==================================== ERRORS ====================================
_________________ ERROR collecting datasets/tests/test_data.py _________________
ImportError while importing test module '/opt/conda/lib/python3.10/site-packages/scipy/datasets/tests/test_data.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/conda/lib/python3.10/site-packages/scipy/datasets/tests/test_data.py:10: in <module>
    import pooch
E   ModuleNotFoundError: No module named 'pooch'

During handling of the above exception, another exception occurred:
/opt/conda/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
/opt/conda/lib/python3.10/site-packages/scipy/datasets/tests/test_data.py:12: in <module>
    raise ImportError("Missing optional dependency 'pooch' required "
E   ImportError: Missing optional dependency 'pooch' required for scipy.datasets module. Please use pip or conda to install 'pooch'.
=========================== short test summary info ============================
ERROR datasets/tests/test_data.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
===================== 12693 deselected, 1 error in 18.77s ======================

I found a relevant commit to the scipy feedstock about this "pooch" dep: conda-forge/scipy-feedstock@87f59ad

@claytonparnell
Copy link
Contributor

Seeing following errors leading to failures

Scipy and scipy-tests are separately available on conda-forge, but the release versions seem to line up. Will make a change to install scipy-tests version matching scipy and see if that resolves.

This was referenced Mar 20, 2024
@claytonparnell claytonparnell mentioned this issue Apr 15, 2024
3 tasks
@TRNWWZ TRNWWZ mentioned this issue Jul 17, 2024
This was referenced Aug 2, 2024
This was referenced Sep 11, 2024
@TRNWWZ TRNWWZ mentioned this issue Oct 28, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants