Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symlinks in Subdirectory #56

Open
alexanderrtaylor opened this issue Apr 8, 2016 · 1 comment
Open

Allow Symlinks in Subdirectory #56

alexanderrtaylor opened this issue Apr 8, 2016 · 1 comment

Comments

@alexanderrtaylor
Copy link

Inside of this:
private FilePath getSourceDirectory(FilePath basePath) throws IOException, InterruptedException {
String subdirectory = StringUtils.trimToEmpty(this.subdirectory);
if (!subdirectory.isEmpty() && !subdirectory.startsWith("/")) {
subdirectory = "/" + subdirectory;
}
FilePath sourcePath = basePath.withSuffix(subdirectory).absolutize();
if (!sourcePath.isDirectory() || !isSubDirectory(basePath, sourcePath)) {
throw new IllegalArgumentException("Provided path (resolved as '" + sourcePath
+"') is not a subdirectory of the workspace (resolved as '" + basePath + "')");
}
return sourcePath;
}

Can we get another clause that will allow for symlinks to also not throw the illegal argument?

@annamataws
Copy link

Hi,

Thank you for your feature request. I have added an item in our backlog to be Triaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants