Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-crt-swift-5-al2-x64:v0.9.18 missing Swift #194

Closed
ganeshnj opened this issue Oct 12, 2022 · 4 comments
Closed

aws-crt-swift-5-al2-x64:v0.9.18 missing Swift #194

ganeshnj opened this issue Oct 12, 2022 · 4 comments
Assignees
Labels
needs-review p3 This is a minor priority issue

Comments

@ganeshnj
Copy link

ganeshnj commented Oct 12, 2022

For some reason aws-crt-swift-5-al2-x64:v0.9.18 doesn't have Swift install however the image used to build has Swift.

I don't have access to 123124136734 AWS account which hosts the image to further debug. Could you check this issue as it is blocking our CI.

@ganeshnj
Copy link
Author

❯ docker buildx build --platform linux/amd64 . -t swift-al2-x64 -f swift-5-al2-x64/Dockerfile
[+] Building 2.4s (10/10) FINISHED                                                                                                                                                                                                                                                          
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                                                   0.0s
 => => transferring dockerfile: 32B                                                                                                                                                                                                                                                    0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                      0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                        0.0s
 => [internal] load metadata for docker.io/library/swift:5.5.3-amazonlinux2                                                                                                                                                                                                            2.2s
 => [internal] load build context                                                                                                                                                                                                                                                      0.0s
 => => transferring context: 35B                                                                                                                                                                                                                                                       0.0s
 => [1/5] FROM docker.io/library/swift:5.5.3-amazonlinux2@sha256:d580ce66ba3cacfaba5eb07aca9771b922678341b79f2f952730b38a2078979d                                                                                                                                                      0.0s
 => CACHED [2/5] RUN yum -y install     curl     sudo     python3     python3-pip     openssl-devel     && yum clean all     && rm -rf /var/cache/yum                                                                                                                                  0.0s
 => CACHED [3/5] RUN python3 -m pip install --upgrade pip setuptools virtualenv     && python3 -m pip install --upgrade awscli     && aws --version                                                                                                                                    0.0s
 => CACHED [4/5] ADD entrypoint.sh /usr/local/bin/builder                                                                                                                                                                                                                              0.0s
 => CACHED [5/5] RUN chmod a+x /usr/local/bin/builder                                                                                                                                                                                                                                  0.0s
 => exporting to image                                                                                                                                                                                                                                                                 0.0s
 => => exporting layers                                                                                                                                                                                                                                                                0.0s
 => => writing image sha256:c15ea3ca65204016cc28079387a702ec10c177890bc619e30c45b40df6648946                                                                                                                                                                                           0.0s
 => => naming to docker.io/library/swift-al2-x64                                                                                                                                                                                                                                       0.0s

~/Developer/repos/aws-crt-builder/.github/docker-images main* ⇣
❯ docker run -it --entrypoint /bin/bash swift-al2-x64                                        
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
bash-4.2# swift --version
Swift version 5.5.3 (swift-5.5.3-RELEASE)
Target: x86_64-unknown-linux-gnu

@ganeshnj
Copy link
Author

~/Developer/repos/aws-crt-builder main* ⇣
❯ docker pull 123124136734.dkr.ecr.us-east-1.amazonaws.com/aws-crt-swift-5-al2-x64:v0.9.18
v0.9.18: Pulling from aws-crt-swift-5-al2-x64
Digest: sha256:2261b40da754e5b4c7f953a32af8c39c9355614cf52249d57daae85d42bf53ae
Status: Downloaded newer image for 123124136734.dkr.ecr.us-east-1.amazonaws.com/aws-crt-swift-5-al2-x64:v0.9.18
123124136734.dkr.ecr.us-east-1.amazonaws.com/aws-crt-swift-5-al2-x64:v0.9.18

~/Developer/repos/aws-crt-builder main* ⇣
❯ docker run -it --entrypoint /bin/bash 123124136734.dkr.ecr.us-east-1.amazonaws.com/aws-crt-swift-5-al2-x64:v0.9.18
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
bash-4.2# swift --version
Swift version 5.5.3 (swift-5.5.3-RELEASE)
Target: x86_64-unknown-linux-gnu
bash-4.2# which
bash: which: command not found

interesting enough, Swift is there, it is which that is not present

https://github.com/awslabs/smithy-swift/blob/12357544ab7376d0b818f5c3acf524e1c38c1f70/smithy-swift-codegen-test/build.gradle.kts#L32

@ganeshnj
Copy link
Author

made a workaround to use swift --version instead which swift to make sure Swift is installed.

@yasminetalby yasminetalby added the needs-triage This issue or PR still needs to be triaged. label Jun 23, 2023
@yasminetalby yasminetalby self-assigned this Sep 20, 2023
@yasminetalby yasminetalby added needs-review p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 20, 2023
@yasminetalby
Copy link
Contributor

Closing this as the issue was fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants