Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake flags duplicated #90

Closed
aajtodd opened this issue Jan 17, 2021 · 1 comment
Closed

cmake flags duplicated #90

aajtodd opened this issue Jan 17, 2021 · 1 comment
Assignees
Labels
p3 This is a minor priority issue

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Jan 17, 2021

looks like cmake args are getting duplicated, unsure if this is coming from crt-builder or somewhere else. If it is from builder we should attempt to dedupe This isn't necessarily a problem right now as the flags all match (and all of the crt projects build obviously) but something we ought to address.

This is from a recent aws-c-http CI build:

cmake -Bbuild/aws-c-http -H. -DCMAKE_INSTALL_PREFIX=/root/aws-c-http/build/install 
-DCMAKE_PREFIX_PATH=/root/aws-c-http/build/install 
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON 
-DCMAKE_BUILD_TYPE=RelWithDebInfo 
-DBUILD_TESTING=ON -DCMAKE_C_COMPILER=/usr/bin/gcc-8 -DCMAKE_CXX_COMPILER=/usr/bin/g++-8 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DLibCrypto_INCLUDE_DIR=build/deps/libcrypto/include 
-DLibCrypto_SHARED_LIBRARY=build/deps/libcrypto/lib/libcrypto.so 
-DLibCrypto_STATIC_LIBRARY=build/deps/libcrypto/lib/libcrypto.a 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DLibCrypto_INCLUDE_DIR=build/deps/libcrypto/include 
-DLibCrypto_SHARED_LIBRARY=build/deps/libcrypto/lib/libcrypto.so 
-DLibCrypto_STATIC_LIBRARY=build/deps/libcrypto/lib/libcrypto.a 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON 
-DENABLE_SANITIZERS=ON -DPERFORM_HEADER_CHECK=ON
@yasminetalby yasminetalby added needs-triage This issue or PR still needs to be triaged. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2023
@yasminetalby yasminetalby self-assigned this Sep 19, 2023
@yasminetalby
Copy link
Contributor

Hello @aajtodd ,

My apologies for the very long delay of answer on this issue. I am personally not able to replicate the issue with the latest version of aws-c-http.

I will close this issue for now as it might have been fixed in since the issue submission.

If you are still experiencing this with the latest version please let me know so we can reopen the issue and work together on investigating the behavior.

Best regards,

Yasmine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants