Copied (spoke) products are not deleted when the hub product is

[RobReus]

When deleting a product via the factory (by setting Status: terminated), the products are not removed from the spokes when the product_generation_method is set to copy. This creates a mess that has to be manually cleaned up.

I looked through the code, and I am not seeing any logic whatsoever to actually delete individual products. Am I correct or am I missing something?

Steps to reproduce

1. Create portfolio with products on the hub
2. Share with spoke
3. Delete product on hub and let the factory pipeline finish
4. Run puppet pipeline

Expected results

I expect the copied product to be deleted once it has been deleted from the portfolio it is copied from.

Actual results

Product not deleted.

[eamonnfaherty]

Thanks for taking the time to raise this @RobReus

This is a gap in functionality at the moment. Sorry for this.

There is something you can do - you can set the products to be inactive using factory. When you run the pipeline that change will propagate to the spokes. When you delete the hub product the spokes will be orphaned but will remain inactive and so new provisioned products cannot be created.

[RobReus]

@eamonnfaherty I was afraid of this. You mean set the versions to inactive/terminated so that the product in itself is useless as it contains no deployable templates anymore? That is a possibility to mitigate this issue for now indeed.

Is it feasible to have a check which compares the imported/shared portfolio with the local one, and creates tasks to delete any local products which are not found in the imported portfolio? If so, I can maybe spend some time on that when I have some time to kill.

[eamonnfaherty]

You are correct in that you would make the product useless.

I would be happy to accept any other contributions you can make. I dont mind having a quick chat about getting started with developing for the framework.

[RobReus]

@eamonnfaherty tried contacting you on the AWS Developers slack but guess you're not monitoring that one. It might be handy to have a quick chat indeed, feel free to contact me on slack anytime.

[jmflynn81]

Hi @eamonnfaherty, we are also seeing this issue. Would be happy to jump on a call when you have a minute and discuss this through and what options we may have going forward.

[myshauno]

I'm experiencing this issue with spoke-local-portfolios which we use for service offerings, the local copy of the portfolio doesn't align with the imported version which is consistently updated to align with our central account offerings where Factory/Puppet infra is placed.

Is there any way currently to terminate products like this or is it still worth just de-activating all product versions manually instead?

[vijayrajarajana]

Hi myshauno,
I am too facing the same issue. Spoke local portfolios is not updating the products with the latest versions. I even tried to delete the spoke local portfolio data from the manifest file and also tried with "Status: terminated" in spoke local portfolio which is also not deleting the products from the service catalog products.

Hi eamonnfaherty,

Can you please help us with this?