Stateful commands + small cache and performance changes #136
+87
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronologos
changed the title
chronologos
changed the title
|
Thanks for the pull request. Quick note on the tests. Looks like they're failing due to a recent change in prompt toolkit. There's a fix out for this: #137 Once that's merged, you would mind rebasing against master so you can pull in that change? That should fix the failing tests. |
chronologos
force-pushed
the
master
branch
2 times, most recently
from
8988b7c
to
89b1562
Compare
|
@jamesls done! |
chronologos
force-pushed
the
master
branch
3 times, most recently
from
2dab240
to
b688ec0
Compare
|
I would love for this to be merged and released. Any reason this hasn't been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stateful Commands
@can be used to add a context to the prompt. e.g.@ec2will implicitly prefix all commands with ec2.exitwill remove the most recently added context. See issue.Cache and Performance
It used to be that every time the user did a tab completion, the autocompleter would have to do a full parse of the entire line. I made some changes on the condition for full parses such that only tab completions with arguments do a full parse.
Also, all_args are cached while there is no change in context.