Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnsNotificationMessage variant for EventBridge #1272

Open
frjonsen opened this issue Nov 11, 2024 · 1 comment
Open

SnsNotificationMessage variant for EventBridge #1272

frjonsen opened this issue Nov 11, 2024 · 1 comment

Comments

@frjonsen
Copy link
Contributor

Type: Feature

Is your feature request related to a problem? Please describe.
In our projects we've opted for EventBridge rather than SNS. EventBridge also has a wrapper, similar to that of SNS, but some different fields. Currently we are unwrapping this message to get the to the actual data in our own in-house framework, but feel that there could be a case for including a variant of the existing SnsNotificationMessage annotation, but for the EventBridge wrapper.

Describe the solution you'd like
A new annotation, such as EventBridgeMessage, as well as a corresponding message converter, similar to SnsMessageConverter.

Describe alternatives you've considered
Defining a model like record EventBridgeMessage<T>(T detail) { }.

@tomazfernandes
Copy link
Contributor

Hey @frjonsen, yep, I think this does make sense.

If you could provide a prototype PR with an integration test so we can have a clearer notion of how that looks that'd be great.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants