Model preffix is not lowercased in TortoiseCRUDRouter

[marcoaaguiar]

When using TortoiseCRUDRouter, the CRUD routers generate a base prefix that has the same casing as the db_model.

For instance, for a router with prefix "/api", and an object CRUD router defined by

router.include_router(TortoiseCRUDRouter(schema=UserPydantic, db_model=User))

The generated CRUD route that appears in the /doc is /api/User, which is quite odd for APIs.

This issue seems to come from the interaction of these 2 lines

fastapi-crudrouter/fastapi_crudrouter/core/tortoise.py

Line 48 in e1a4a2b

prefix=prefix or db_model.describe()["name"].replace("None.", ""),

and

fastapi-crudrouter/fastapi_crudrouter/core/_base.py

Line 49 in e1a4a2b

prefix = str(prefix if prefix else self.schema.__name__.lower())

Since the prefix is defined in the TortoiseCRUDRouter, it is never lowercased

This might be intended. Anyway, this behavior can be circumvented by passing prefix to the TortoiseCRUDRouter.

[awtkns]

Hi @marcoaaguiar thanks for reporting this.

In #65 I've changed it so that all prefixes are lowercase. Even if you specify prefix="MyModel" it would turn into "mymodel". That being said, this could cause problems if someone wanted an uppercase path prefix (for whatever reason). Alternatively, I can just fix the tortoise issue,

Thoughts?

[marcoaaguiar]

Hi Adam, I believe that would fix the issue.

I started using this package this morning, and it's great to see that it is under development/maintenance!
The only feature that seems to be missing is filtering, but it seems that soon it will be available (#61).

When #65 is merged, feel free to close this issue.

[awtkns]

Awesome! Thanks for the feedback, filtering will be released soon 😃