Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config data source #786

Open
ffe9f8 opened this issue Feb 21, 2024 · 8 comments · May be fixed by #791
Open

Update config data source #786

ffe9f8 opened this issue Feb 21, 2024 · 8 comments · May be fixed by #791
Assignees

Comments

@ffe9f8
Copy link
Contributor

ffe9f8 commented Feb 21, 2024

Update the "EVM contract addresses" and "Assets" on the Mainnet and Testnet pages to pull from these two JSON files:

Mainnet: https://axelar-mainnet.s3.us-east-2.amazonaws.com/configs/mainnet-config-1.x.json
Testnet: https://axelar-testnet.s3.us-east-2.amazonaws.com/configs/testnet-config-1.x.json

@StephenFluin
Copy link
Collaborator

@ffe9f8 who did this task come from? The new json is missing network_id (eg ethereum-2). Looks like the only difference is in capitalization (eg Ethereum in old data ethereum in new), but I want to double check.

Also, I need to know where icons referenced in the data like /images/chains/ethereum-sepolia.svg is hosted?

@StephenFluin
Copy link
Collaborator

@ffe9f8 I'm also seeing a bunch of missing block explorer URLs.

StephenFluin added a commit that referenced this issue Feb 26, 2024
@StephenFluin StephenFluin linked a pull request Feb 26, 2024 that will close this issue
@StephenFluin
Copy link
Collaborator

@ffe9f8 Avalanche is missing gateway and gas service addresses. We'll need to make sure this JSON is validated as correct before we rely on it, unless we want to do extra work in the web app to validate it and fail gracefully.

@ffe9f8
Copy link
Contributor Author

ffe9f8 commented Feb 29, 2024

@ffe9f8 who did this task come from? The new json is missing network_id (eg ethereum-2). Looks like the only difference is in capitalization (eg Ethereum in old data ethereum in new), but I want to double check.

Also, I need to know where icons referenced in the data like /images/chains/ethereum-sepolia.svg is hosted?

From @milapsheth. Context

@StephenFluin
Copy link
Collaborator

@StephenFluin
Copy link
Collaborator

Native currency of ethereum isn't weth

@StephenFluin
Copy link
Collaborator

Can you clarify this too factory/osmo1mlng7pz4pnyxtpq0akfwall37czyk9lukaucsrn30ameplhhshtqdvfm5c/ulvn?

@StephenFluin
Copy link
Collaborator

Still blocked by https://github.com/axelarnetwork/chains/pull/515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants