-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation incorrectly lists --project-root and --config-path parameters for oranda build #683
Comments
My primary use case is to build an Oranda site into a separate directory, e.g.
I'm interested in implementing this feature! I dug into the code starting with where But if I understand the code correctly (and I might not!), it's best not to change the behavior of It looks like the intended way-of-doing-things is to build the site alongside the repo and put it in Am I correct here, or am I being too self-discouraging about contributing? Are there other issues / PRs around this that I might start with? |
ah, you're right, I think that bit of the documentation is outdated. it would of course be nice to support an arbitrary source (and destination!) directory, but yeah, that doesn't exist as of right now. if you want to put up a PR removing that bit from the docs that'd be appreciated! |
Happy to! I made a PR for the quick change here: #685 |
oops! forgot to close this after merge |
Loving Oranda!! I just now found an issue where the docs refer to a feature that seems to not yet have been implemented. I wasn't able to find contributing guidelines, so I apologize if this issue isn't formatted correctly.
TLDR: The Oranda docs suggests one can pass a parameter
--project-root
tooranda build
, but one can't.As of
0.6.1
, this does not work, andoranda build -h
does not show the--project-root
or--config-path
parameters:Digging into the argument-parser source code shows a bit of context around the
build
command.(I've only tried
--project-root
but it seems--config-path
has the same issues.)The text was updated successfully, but these errors were encountered: