Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Java support needed for one of the linting checks is deprecated. #513

Closed
mmunro-ltrr opened this issue Jul 29, 2022 · 2 comments · Fixed by #560
Closed

The Java support needed for one of the linting checks is deprecated. #513

mmunro-ltrr opened this issue Jul 29, 2022 · 2 comments · Fixed by #560
Assignees
Labels
high priority Must get done for this milestone

Comments

@mmunro-ltrr
Copy link
Member

The linting checks in arizona-bootstrap include the Nu Html Checker (vnu-jar), which needs a Java environment to run. To standardize this in a way that works for local development as well as on GitHub actions. The Dockerfile includes this by lifting it from a pre-built standard OpenJDK Docker image, but this is now deprecated
docker-library/openjdk#505

Conditions of satisfaction

Some other mechanism should include an actively maintained Java environment to support the vnu-jar checker.

@tellison
Copy link

tellison commented Aug 4, 2022

The recommended replacements are the official images of Eclipse Temurin

@mmunro-ltrr
Copy link
Member Author

@tellison: thanks for the advice — I had looked at those images, but we are currently doing something strange with a

COPY --from=openjdk:11.0.15-jre-slim-bullseye "$JAVA_HOME" "$JAVA_HOME"

in our Dockerfile to lift just part of the old OpenJDK image, relying on both being based on Debian Bullseye. It's probably time to opt for something less fragile instead.

@danahertzberg danahertzberg added the high priority Must get done for this milestone label Sep 21, 2022
@danahertzberg danahertzberg moved this from Todo to Needs Review in 2.5.0 Release (9/23/22) Sep 21, 2022
joeparsons pushed a commit that referenced this issue Sep 21, 2022
…, and change Java support for linting. (#560)
Repository owner moved this from Needs Review to Done in 2.5.0 Release (9/23/22) Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Must get done for this milestone
Projects
No open projects
3 participants