Skip to content
This repository has been archived by the owner on Aug 1, 2021. It is now read-only.

Newer release on pypi #178

Open
Celelibi opened this issue Apr 1, 2020 · 4 comments · Fixed by #183
Open

Newer release on pypi #178

Celelibi opened this issue Apr 1, 2020 · 4 comments · Fixed by #183

Comments

@Celelibi
Copy link

Celelibi commented Apr 1, 2020

Hello,

I guess this is more or less a follow up on issue #170.

Installing disco-py from pip prove to be challenging. The version on pypi depends on an older version of gevent. This older version of gevent doesn't compile with python 3.8.

So, it's pretty much uninstallable from the pypi repository on any system that adopted python 3.8 already.

@Nekkowe
Copy link

Nekkowe commented Apr 19, 2020

I just ran into this same issue trying to troubleshoot for a friend; the install does indeed fail under Python 3.8.

@Nekkowe
Copy link

Nekkowe commented Apr 19, 2020

In accordance with issue #107, downgrading to 3.7 allowed us to install disco via the github branch.
Trying to install via pip did not work on either 3.8 nor 3.7.

@casperdcl
Copy link
Contributor

casperdcl commented Sep 20, 2020

Is there any reason why requirements.txt are pinned? Based on browsing a few closed issues and PRs, it seems it may be a good idea to change https://github.com/b1naryth1ef/disco/blob/master/requirements.txt#L1 to say e.g. gevent>=1.3.0 to prevent these issues in future...

The same goes for the other dependencies too (>= not ==).

casperdcl added a commit to casperdcl/disco that referenced this issue Sep 20, 2020
b1naryth1ef pushed a commit that referenced this issue Oct 27, 2020
* unpin dependencies

- fixes #107
- fixes #170
- fixes #173
- fixes #178

* bound deps
@b1naryth1ef b1naryth1ef reopened this Oct 27, 2020
@b1naryth1ef
Copy link
Owner

Found the time to release 0.0.14 rc1 which is built off the latest master. If things look fine in a few days I'll cut a 0.0.14 as a final "maintenance mode" release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants