New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate different safety confirmation targets. #49

Open

KonradStaniec opened this issue Sep 18, 2023 · 1 comment

Labels

Severity: Medium

Collaborator

KonradStaniec commented Sep 18, 2023

Currently we are using different safety confirmation targets for different transactions:

unbonding - https://github.com/babylonchain/btc-staker/blob/main/staker/stakerapp.go#L232
spend stake - https://github.com/babylonchain/btc-staker/blob/main/staker/stakerapp.go#L200

This maybe confusing for everybody. Some exsisting context:
#46 (comment)
#48 (comment)

KonradStaniec added the Severity: Medium label

KonradStaniec mentioned this issue

Adapt spend stake endpoint to unbonding tx #48

Merged

Contributor

filippos47 commented Sep 19, 2023

@KonradStaniec A bit out of scope, but let's also parameterize all these values 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment