We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
num_pub_rand
@bap2pecs cloned issue babylonchain/babylon-contract#186 on 2024-06-23:
in FP, we will add logic in fast sync: for lastCommitStartHeight, val := range lastCommitPR { if endHeight > lastCommitStartHeight+val.NumPubRand-1 { return nil, nil } } if both lastCommitStartHeight and val.NumPubRand is 0, integer underflow can happen. but in reality, we shouldn't allow NumPubRand to be 0. it should at least have 1 pubrand. we should enforce this check in the CW contract
in FP, we will add logic in fast sync:
for lastCommitStartHeight, val := range lastCommitPR { if endHeight > lastCommitStartHeight+val.NumPubRand-1 { return nil, nil } }
if both lastCommitStartHeight and val.NumPubRand is 0, integer underflow can happen.
but in reality, we shouldn't allow NumPubRand to be 0. it should at least have 1 pubrand.
NumPubRand
we should enforce this check in the CW contract
The text was updated successfully, but these errors were encountered:
@bap2pecs commented on 2024-07-08:
closing for https://www.github.com/babylonchain/pm-integration/issues/5
Sorry, something went wrong.
No branches or pull requests
@bap2pecs cloned issue babylonchain/babylon-contract#186 on 2024-06-23:
The text was updated successfully, but these errors were encountered: