Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] false positive AWS key pre-check #58

Open
enricorotundo opened this issue Feb 16, 2023 · 1 comment
Open

[example] false positive AWS key pre-check #58

enricorotundo opened this issue Feb 16, 2023 · 1 comment

Comments

@enricorotundo
Copy link
Contributor

❯ git commit -m "examples general readme"
Check for merge conflicts................................................Passed
Detect AWS Credentials...................................................Passed
Detect Private Key.......................................................Passed
Check Yaml...........................................(no files to check)Skipped
Check JSON...........................................(no files to check)Skipped
Extra Credential Checking................................................Failed
- hook id: extra-credential-checking
- exit code: 1

=========== Possible AWS Access Key IDs ===========


=========== Possible AWS Secret Access Keys ===========
182:    "hash": "<REDACTED>"
❯ grep -r <REDACTED> ./
.//workload-onboarding/custom-containers/index.ipynb:        "hash": "<REDACTED>"
.//workload-onboarding/bacalhau-docker-image/index.ipynb:        "hash": "<REDACTED>"
.//workload-onboarding/rust-wasm/index.ipynb:        "hash": "<REDACTED>"
.//workload-onboarding/python-script/index.ipynb:        "hash": "<REDACTED>"
.//workload-onboarding/r-hello-world/index.ipynb:        "hash": "<REDACTED>"
.//workload-onboarding/r-custom-docker-prophet/index.ipynb:        "hash": "<REDACTED>"
.//workload-onboarding/index.ipynb:        "hash": "<REDACTED>"
....

Seems like VS code interpreter confuses the pre-check

cat .//index.ipynb

....
 "metadata": {
  "kernelspec": {
   "display_name": "Python 3 (ipykernel)",
   "language": "python",
   "name": "python3"
  },
  "language_info": {
   "codemirror_mode": {
    "name": "ipython",
    "version": 3
   },
   "file_extension": ".py",
   "mimetype": "text/x-python",
   "name": "python",
   "nbconvert_exporter": "python",
   "pygments_lexer": "ipython3",
   "version": "3.9.16"
  },
  "vscode": {
   "interpreter": {
    "hash": "<REDACTED>"
   }
  }
 },
 "nbformat": 4,
 "nbformat_minor": 4
}
@enricorotundo
Copy link
Contributor Author

for the record, <REDACTED> is 64 char long and starts with 21fd...

@enricorotundo enricorotundo changed the title false positive AWS key pre-check [example] false positive AWS key pre-check Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant